On Sun, Jul 29, 2007 at 12:18:15PM -0400, Joseph Jezak wrote: >> -#include <stdio.h> >> #include "blk_dmg.h"
> Well, that's wicked annoying. I added that to fix build errors on FC7. > I've reverted that change, can someone running FC7 see if it still builds > and if not, please post the whole error. Whatever is going on there is no way that including stdio.h prior to zlib.h should break anything (or be required for that matter). I've just had a brief look and as far as I can tell it works perfectly well with either _LARGEFILE64_SOURCE or _FILE_OFFSET_BITS set with both 1.2.3 and 1.2.3.3 (the latter is what's in Debian unstable but is a pre-release so most people are at 1.2.3). If there *are* problems with the zlib headers it would be best to work out what they are and try to resolve them prior to the next zlib release. The only thing I can think that might break is if blk_dmg.h tries to set one or the other of those defines after stdio.h has been included. Note that I've no idea what version of Mac on Linux Elimar was experiencing trouble with and have been entirely unable to reproduce the problem he is reporting. If someone could provide reproduction instructions or (better yet) a cut down test case I could have a look. Note also that the gzio API in zlib prior to 1.2.3.mumble prereleases doesn't cope with large files at all, though you don't seem to be using it so that shouldn't be an issue. -- "You grabbed my hand and we fell into it, like a daydream - or a fever."
signature.asc
Description: Digital signature
