Package: qla2x00-source
Version: 7.01.01-2
Severity: normal
Tags: patch
The qla2x00 "makefile" requires an "SMP=1" argument if the module is to
be build for an SMP kernel. The attched patch to the
qla2x00/debian/rules determins if this is an SMP build by looking at the
kernel source header files and then passes "SMP=1" to the upstream make
file if needed.
Note that the patch also gives the kernel version to the make command so
that the module is build for the required kernel rather than the running
kernel. (less than ideal if your root file system is on a fibre-channel
connected device!)
I'm of the opinion that we should pass "INCLUDEDIR=" as an argument to
the upstream makefile and also maybe "KERNELDIR=" rather than patching
the upstream makefile but that is upto the package maintainer!
Alex Owen
---8<---
--- ./rules Fri Apr 15 16:23:53 2005
+++ qla2x00/debian/rules Fri Apr 15 16:38:31 2005
@@ -111,6 +111,9 @@
pmodules = $(package)-modules-$(non_epoch_version)
psource = $(package)-source
+#find out if kernel is configured for SMP
+SMP = $(shell if ( grep "define CONFIG_SMP 1" $(KSRC)/include/linux/autoconf.h
>/dev/null ) ; then echo SMP=1 ; fi)
+
# Prepares the package for distribution. Intended for the kernel
# maintainer.
kdist: kdist_clean kdist_config kdist_image
@@ -176,7 +179,7 @@
dh_clean -k
# Build the module
- $(MAKE)
+ $(MAKE) all KERNVER=$(non_epoch_version) $(SMP)
# Install the module
$(MAKE) install KERNVER=$(non_epoch_version)
DESTDIR=$(CURDIR)/debian/$(pmodules)
---8<---
-- System Information
Debian Release: 3.0
Architecture: i386
Kernel: Linux falcon 2.4.27-686-smp-lvm-vfslock #1 SMP Mon Sep 27 10:07:09 BST
2004 i686
Locale: LANG=C, LC_CTYPE=C
Versions of packages qla2x00-source depends on:
ii debhelper 4.0.2 helper programs for debian/rules
ii make 3.79.1-14 The GNU version of the "make" util
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
