Package: libbtctl
Version: 0.9.0-1
Severity: important
Tags: patch
Usertags: implicit-pointer-conversion

Our automated buildd log filter[1] detected a problem that is likely to
cause your package to segfault on architectures where the size of a
pointer is greater than the size of an integer, such as ia64 and amd64.

This is often due to a missing function prototype definition.

_XOPEN_SOURCE must be defined to use strptime. Though there is a
#define for this just before the time.h include, something else is
probably causing <time.h> to be included earlier and without the
_XOPEN_SOURCE prereq (I haven't dug too deeply into this).

A solution to this is to move the _XOPEN_SOURCE definition up higher
in the source file - however, this alone turns off other prototypes
including timegm(). The following patch defines _GNU_SOURCE instead,
which enables a superset of features.

[1]http://people.debian.org/~dannf/check-implicit-pointer-functions

----- Forwarded message from Debian/IA64 non-US Build Daemon <[EMAIL 
PROTECTED]> -----

X-Spam-Checker-Version: SpamAssassin 3.1.7-deb (2006-10-05) on ldl.fc.hp.com
X-Spam-Level: 
X-Spam-Status: No, score=-1.4 required=3.5 tests=AWL,BAYES_00,UNDISC_RECIPS 
        autolearn=disabled version=3.1.7-deb
X-Virus-Scanned: Debian amavisd-new at ldl.fc.hp.com
Subject: Log for successful build of libbtctl_0.9.0-1 (dist=unstable)
From: Debian/IA64 non-US Build Daemon <[EMAIL PROTECTED]>
Date: Mon, 23 Jul 2007 23:16:28 +0100
To: undisclosed-recipients: ;
X-PMX-Version: 5.3.1.294258, Antispam-Engine: 2.5.1.298604, Antispam-Data: 
2007.7.23.145932
Debian-Buildd-Error: Yes

Function `strptime' implicitly converted to pointer at btobex.c:290

----- End forwarded message -----

-- 
dann frazier

--- libbtctl-0.9.0.orig/src/btobex.c	2007-03-05 17:01:00.000000000 -0700
+++ libbtctl-0.9.0/src/btobex.c	2007-07-23 18:31:42.000000000 -0600
@@ -16,13 +16,13 @@
  * License along with this library; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA
  */
+#define _GNU_SOURCE /* glibc2 needs this */
 #include <config.h>
 
 #include <stdio.h>
 #include <glib.h>
 #include <glib-object.h>
 #include <assert.h>
-#define _XOPEN_SOURCE /* glibc2 needs this */
 #include <time.h>
 
 #include "btobex.h"

Reply via email to