Hi Joachim, On Tue, Jul 10, 2007 at 06:32:50PM +0200, Joachim Breitner wrote: > Hi, > > Am Montag, den 09.07.2007, 21:20 +0200 schrieb Peter Colberg: > > Package: osdsh > > Version: 0.7.0-9 > > Severity: normal > > Tags: patch > > > > While upgrading osdsh from a local version to 0.7.0-9, I noticed > > that osdctl started to hang again when executed directly after > > osdsh. Even with patch 09-process-running-checks.dpatch applied, > > there remains a race condition. > > > > With the current design, the osdsh parent process forks a child > > process, writes the child's pid to a file and exits. If osdctl is > > started directly in succession, the fifo might not exist, as the > > child process might not have created it yet. > > > > With my local version, I had tested a real fix for this problem > > (and subsequently forgotten about the patch). The only way to know > > for sure that the fifo exists after osdsh has exited is to simply > > create the fifo *before* forking the child process. > > Thanks for the patch. Does this make the patch > 09-process-running-checks.dpatch obsolete?
As a fix to the problem with starting osdsh and osdctl in succession, this patch is indeed not needed anymore. However, as a general check as to whether osdsh is actually running at all, why not keep it? It would not seem to hurt, apart from deviating further from upstream. Regards, Peter -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
