Package: git-buildpackage Version: 0.3.2 Severity: minor Hi,
git-import-orig will only work when called from a Git repository. I personally understand it's contract as "do the relevant things when you want to import an upstream tarball into a git-managed Debian package", and it fits well in that role. git-import-dsc will ignore completely the git repository if it's called from a git repository, and will instead create a $source subdirectory, a git repository within, import the tarball just like git-import-orig does, import the diff. I found this behavior surprizing as I naturally imaginated the contract of git-import-dsc as "do the relevant things when you want to import a .dsc and everything it refers to into a git-managed Debian package". It seems its contract is more "I now want to manage this package using git starting with this .dsc, please prepare me anything I need". I would prefer it if git-import-dsc would behave similarly to git-import-orig, i.e.: - either a) both commands try to import stuff into the current directory and fail if it's not a git repo OR b) both commands expect to work on the git repo below the $source subdirectory - either a) both commands create the git repo OR b) both commands fail when the git repo doesn't exist If you ask me, I'd better see "import" commands fail when a git repo in the current dir doesn't exist and use it otherwise. If you wanted to offer an easy way to create new git repos to manage Debian packages, perhaps this should be a separate command instead, for example git-init-package, perhaps with optional --from-dsc and --from-orig? This might be the occasion to create a .git/gbp.conf with the arguments passed to git-init-package. I personally wouldn't need such a command, and I would like to use the workflow: git-init, git-import-orig, git-import-dsc, git-import-dsc. Bye, -- System Information: Debian Release: lenny/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.22-rc6-686 (SMP w/2 CPU cores) Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages git-buildpackage depends on: ii devscripts 2.10.6 Scripts to make the life of a Debi ii git-core 1:1.5.2.3-1 fast, scalable, distributed revisi ii python 2.4.4-6 An interactive high-level object-o ii python-support 0.6.4 automated rebuilding support for p git-buildpackage recommends no packages. -- no debconf information -- Loïc Minier