Hi Marc Thanks very much for your comments on the patch. I'll incorporate them into a revised version.
On 6/27/07, Marc Singer <[EMAIL PROTECTED]> wrote:
I had another thought about this. It may be worthwhile to make sure to install APEX only if it is already present in the Loader partition and if there is a Loader partition. Some people may choose to install APEX as the primary boot loader.
Currently, the patch does check for a partition called "Loader", but it does not check whether APEX is present. However, I am not sure that this step is necessary (see below). + mtdloader=$(mtdblock Loader) + if [ -z "$mtdloader" ]; then + error "Cannot find mtd partition 'Loader'" + fi
There is a mkboot script for x86, should we do the same?
I like the idea of creating a separate script to flash APEX. We add the script to the apex-nslu2 package, and run it as part of postinst when APEX is upgraded. In this case, we shouldn't need to check if APEX is present in the Loader partition, because we can assume that APEX is being installed as the second stage bootloader. With reference to your comment on using APEX as the primary bootloader: I think that it would be dangerous at the moment to provide an easy way for people to flash APEX as the primary bootloader, because people may actually do it without a full appreciation of what they are doing. BTW, I'll be away for from Friday this week to Sunday next week, so I won't have time to work on the changes until after the 8th of July. Gordon -- Gordon Farquharson GnuPG Key ID: 32D6D676 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
