severity 429457 important
tag 429457 moreinfo
thanks

On Mon, 18 Jun 2007, Olleg Samoylov wrote:
> I doesn't know why only I see it. /etc/init.d/fcron does not have rm -f
> pidfile. And fcron on start see pid file and silently exit. The patch is
> applied.

You should *never* need to remove pidfiles on init scripts if they are being
handled properly.  If you do, something else is broken.

The daemon needs to remove it itself, AND it also needs to cope with stale
pidfiles.  Anything else is broken and won't work right on all possible
scenarios.

So the patch is not the way to fix the problem.

Looking at fcron.c, fcron does remove the pidfile unless you kill -9 it, and
it uses locking to know if an existing pidfile is good or not, which should
be good even for kill -9 as long as you let it use flock(), which Debian
builds do.

Did you actually HAVE any malfunction problems with Debian-built fcron and
its pidfile?

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to