Am Dienstag, den 29.05.2007, 22:36 +0900 schrieb Junichi Uekawa:
> Hi,
>
> >
> > The manpage reads for the --debianonly option of dpatch-edit-patch:
> > [..] The optional argument is the path to the upstream tarball [..]
> >
> > - From my understanding, I expected, that I just need to give the path to
> > the tarball, excluding the tarball name (I mean, from the changelog
> > entry, dpatch-edit-patch should be able to determine the .orig.tar.gz
> > name itself). So what is it: A misunderstanding at my side? Then the
> > manpage should be slidely adjusted. Or is this option broken?
> >
> > PS: I would suggest the following:
> > - - check if the path is a file or directory
> > - - if it is a file, then consider it the upstream tarball
> > - - if it is a directory, then expect the .orig.tar.gz inside this
> > directory (create the .orig.tar.gz tarball name from debian/changelog)
> >
> > What is your opinion?
> >
>
> Sounds mostly good.
>
> The only problem is that I don't use this feature much, so I don't
> really have an opinion on this point. Could you prepare a patch?
I have a first interesting solution: Put the PACKAGENAME variable
determination before reading in any configure file. This allows for
example the following use case:
~/.dpatch.conf:
conf_origtargzpath="/usr/local/src/packages/${PACKAGENAME}"
dpatch-edit-patch -b my_patch
So I don't need to retype the whole path every time. Maybe you want to
put the variable creation for UPSTREAMVERSION and ORIGTARGZ before the
configuration file inclusion too.
What is your opinion? BTW: What is the path attribute of the
--debianonly option for, when you also provide --origtargzpath? Isn't
this redundant? However, here is a workaround to my original report:
Simply test, if the given attribute is a directory: then set
DPEP_ORIGTARGZPATH; else set DPEP_ORIGTARGZ:
/usr/share/dpatch/dpatch-edit-patch.functions:
-b|--debianonly) DPEP_DEBIANONLY=1; [[ -d $2 ]] && \
DPEP_ORIGTARGZPATH="$2" || DPEP_ORIGTARGZ="$2"; \
shift 2;;
Regards, Daniel
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
