On Fri, Jun 08, 2007 at 10:58:36AM -0700, Cameron Dale wrote:
> severity 428076 wishlist
> thanks
> 
> On 6/8/07, Mike Mestnik <[EMAIL PROTECTED]> wrote:
> >http://www.tuxdistro.com/rssinfo.php
> >
> >All of these RRS feeds use the same "file_name".
> >
> >Like:
> >http://www.tuxdistro.com/torrents-details.php?id=323&hit=1
> >http://www.tuxdistro.com/torrents-details.php?id=322&hit=1
> >
> >I.E. torrents-details.php
> >ect.
> 
> These RSS feeds don't have links to torrents, and therefore aren't
> meant to be used in the way that you are trying to. Instead they have
> links to HTML pages containing details about the torrents. To download
> the torrents you have to click on the download link:
> 
> http://www.tuxdistro.com/download.php?id=323&name=SabayonLinux-x86-3.3.iso.torrent
> http://www.tuxdistro.com/download.php?id=322&name=SabayonLinux-x86_64-3.3.iso.torrent
> 
> And if you add these download URLs to Torrentflux the torrents get
> added properly (with the correct names).
> 
> The reason adding the details links to Torrentflux partly works (you
> do get the torrent file), is that it has built in rewriting rules for
> some major torrent sites (mininova, isohunt, torrentspy, ...) to
> support getting torrent files from links like this and the tuxdistro
> site is very close to one of them. (See the FetchTorrent function in
> functions.php) So I have changed your bug to a wishlist one, as what
Thank you.

I will take a look, however I think a general solution for this may be
a good idea.  I know there is file_name uniq checking and an error,
perhaps that should cause more of the original URL to be included in
the file_name... kinda tough to code though.  A counter like what
other tools(wget) do would be an easy fix.

I can guess that .torrent files may be accessed using a
"torrent.php?id=xyz" URL.  Perhaps support for this should be
included.

Perhaps an md5 of this "?passkey=12345" string is a good replacement. :)

> you really want (I think) is a rewriting rule for tuxdistro.com links
> to be added. If you do want that, I can see if upstream wants to add a
> rule for that site (though it might be tough, as that site doesn't
> seem so popular).
> 
> >Here is the code and my work around.
> >
> >index.php, line 343:
> >if(! $url_upload == '')
> >{
> >    $arURL = explode("/", $url_upload);
> >    $file_name = $arURL[count($arURL)-1]; // get the file name
> >    $file_name = urldecode($file_name);
> >    $file_name = str_replace(array("'",","), "", $file_name);
> >    $file_name = stripslashes($file_name);
> >    $ext_msg = "";
> >
> >    // Check to see if url has something like ?passkey=12345
> >    // If so ?remove it?
> >//    if( ( $point = strrpos( $file_name, "?" ) ) !== false )
> >//    {
> >//        $file_name = substr( $file_name, 0, $point );
> >//    }
> 
> I won't be using this, as there is a reason these are removed from the
> saved file name (so everyone can't see your passkey).
> 
Perhaps an md5 of this string is a good solution. :)

> Thanks for the report,
> Cameron


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to