Am Mittwoch, den 30.05.2007, 14:47 +0200 schrieb Andreas Tille: > On Wed, 30 May 2007, Daniel Leidert wrote: > > > Am Dienstag, den 29.05.2007, 20:27 +0200 schrieb Adrien Cunin: > > > >> We added a .desktop file in Ubuntu: > >> > >> diff -pruN 0.2.5.0-1/debian/gnumed-client.desktop > >> 0.2.5.0-1ubuntu1/debian/gnumed-client.desktop > >> --- 0.2.5.0-1/debian/gnumed-client.desktop 1970-01-01 01:00:00.000000000 > >> +0100 > >> +++ 0.2.5.0-1ubuntu1/debian/gnumed-client.desktop 2007-05-07 > >> 16:53:42.000000000 +0100 > >> @@ -0,0 +1,10 @@ > >> +[Desktop Entry] > >> +Type=Application > >> +Encoding=UTF-8 > >> +Name=GNUmed > >> +GenericName=GNUmed > >> +Comment=Paperless Medical Practice Management > >> +Icon=gnumed > >> +Exec=/usr/bin/gnumed > >> +Terminal=false > >> +Categories=Application;MedicalSoftware; > >> > >> This file should be installed in /usr/share/applications/, and the > >> icon client/bitmaps/gnumed.xpm should in installed > >> in /usr/share/pixmaps/. > >> You can also add dh_desktop in debian/rules. > > Great - thanks for the patch. I'll upload this soon. Perhaps I'll wait > ten days to let gnumed-client propagate to testing before changing the > package, but I see this as a very reasonable enhancement. > > > And once again: There is no MimeType field, so calling dh_desktop is > > useless and adds a useless call of update-desktop-database to the > > debhelper scripts. > > Well, but does this really harm? I've thought useless dh_* calls > just do nothing - so if you call dh_cron when not providing any > corn file just nothing happens - except that debian/rules just contains > a useless call.
Unfortunately this is not the case for dh_desktop. Just take a look at it's code (just a few lines). It adds the update-desktop-database call in every case a .desktop file is found, independent from it's content - wasting time and resources by simply rebuilding the database without the necessity - that's why I'm not happy with calling this script without reason. This debhelper script needs some improvement (e.g. checking for MimeType field, before it adds the update-desktop-database call) to handle the situation better. I know. > > Don't do this. Further this file is invalid: > > Application is not a valid category. You should better use > > "Education;Science;MedicalSoftware;" as suggested by the specification. > > You can check such issues yourself with the desktop-file-validate tool. > > Thanks for this hint Maybe lintian could do checking .desktop files for validity. If I find some time, I will try to evaluate the situation and try to fix things. @Adrien: I saw this suggestion several times by Ubuntu developers trying to bring .desktop files to Debian. That's why I'm now a little bit annoyed seeing this suggestion again and again. The MOTU-guide at https://wiki.ubuntu.com/MOTU/Packages/DesktopFiles simply is wrong in this point. To tell the good news: It already suggests to run desktop-file-validate. The bad news: Seems, this is not done. Regards, Daniel -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
