On Tue, May 29, 2007 at 07:10:51PM +0200, Alain Bench wrote:

>  On Saturday, May 26, 2007 at 20:39:04 +0200, Lionel Elie Mamane wrote:

>> The attached patch changes all calls to strtok to the reentrant
>> strtok_r, fixing that problem.

>     But strtok_r() doesn't exist on some platforms, so I fear this
> can't be a general solution.

IMHO, then fundamentally, the only general solution is:

 - don't use strtok in at least one of url_parse_mailto and
   mutt_parse_references, and the same for all pairs of functions that
   can be in the call stack at the same time. This looks complex to
   me, unless you just decide never to use strtok.

 OR

 - ship a private copy of strtok_r or a similarly reentrant
   function. I suppose that autoconf can check for availability of
   strtok_r and #define HAVE_STRTOK_R, and things like that (with
   AC_REPLACE_FUNCS?).

-- 
Lionel


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to