On Tue, 2007-05-29 at 16:19 +0200, Robert Millan wrote:
> On Mon, May 28, 2007 at 03:42:51AM +0100, Sam Morris wrote:
> >
> > A partial patch was suggested which solves the issue for now:
> >
> > Index: disk/raid.c
> > ===================================================================
> > RCS file: /cvsroot/grub/grub2/disk/raid.c,v
> > retrieving revision 1.3
> > diff -u -p -r1.3 raid.c
> > - --- disk/raid.c 17 May 2007 23:23:03 -0000 1.3
> > +++ disk/raid.c 21 May 2007 13:10:25 -0000
> > @@ -344,7 +344,10 @@ grub_raid_scan_device (const char *name)
> > err = grub_disk_read (disk, sector, 0, GRUB_RAID_SB_BYTES, (char *) &sb);
> > grub_disk_close (disk);
> > if (err)
> > - - return 0;
> > + {
> > + grub_errno = GRUB_ERR_NONE;
> > + return 0;
> > + }
> >
> > /* Look whether there is a RAID superblock. */
> > if (sb.md_magic != GRUB_RAID_SB_MAGIC)
>
> Did you confirm this works? Has it been committed to upstream CVS?Works fine, but doesn't appear to have been committed. I guess the developers want to decide how to improve grub's general error/warning handling code rather than applying similar patches all over the source tree; there are currently many places where modules error out instead of just displaying a warning. -- Sam Morris http://robots.org.uk/ PGP key id 1024D/5EA01078 3412 EA18 1277 354B 991B C869 B219 7FDB 5EA0 1078
signature.asc
Description: This is a digitally signed message part
