On 05/24/07 08:15, Wesley J. Landaker wrote: > package googleearth-package > severity 425798 wishlist > tag 425798 unreproducible > thanks > > On Wednesday 23 May 2007 22:40:54 Ron Johnson wrote: >> Package: googleearth-package >> Version: 0.1.0 >> Severity: important >> >> >> The program still downloads the old v4.0 binary. >> >> In order to get v4.1, line 5 of /usr/bin/make-googleearth-package >> needs to be changed to: >> GoogleEarth_bin_URL="http://dl.google.com/earth/client/current/GoogleEart >> hLinux.bin" > > I can't reproduce this; it currently downloads 4.1. It did the day they > released 4.1 and as of 5 seconds ago gets 4.1.7076.4458. It works for me > from several different sites. Are you sure you aren't getting a cached copy > from a web proxy or you already have GoogleEarthLinux.bin in your current > directory or something like that? > > Anyway, I'll will try to verify what URL is "canonical" and use that. If you > are having still having trouble and you can always build off your own > downloaded binary.
A left-over GoogleEarthLinux.bin must have been it, since I just tries it with your URL and it build v4.1. I *really* think it's counter-intuitive to automatically use a pre-existing GoogleEarthLinux.bin, since make-googleearth-package leaves the just-downloaded GoogleEarthLinux.bin in place. Adding a --do-not-download or --cleanup would make it more "just do it", IMO. Attached is a patch to implement "--cleanup". >> Also, bug #378362 is "alive". > > I welcome good, constructive patches. =) Sadly, I know nothing of making Debian packages. :\ -- Ron Johnson, Jr. Jefferson LA USA Give a man a fish, and he eats for a day. Hit him with a fish, and he goes away for good!
19a20 > echo ' --cleanup Delete installer when finished building package' > >&2 86a88,89 > elif [ "$1" == "--cleanup" ]; then > OPT_CLEANUP=1 359a363,365 > if [ "$OPT_CLEAN" == "1" ]; then > rm $OPT_FILE > fi
