Package: module-assistant Version: 0.8.2 Severity: normal Tags: patch I have been trying to track-down a bug in the ndiswrapper-source package where building the module with the --rootcmd option of make-kpkg results in file permisisons errors. My search has lead to the call to kdist_clean from common-rules.mk for kdist_image. The call is executed without the $(ROOT_CMD) as a normal user, which causes the errors when dh_clean is executed. Although this could be considered a bug in ndiswrapper-source (and I will submit it there if you suggest that I do so), I think the problem should be solved in module-assistant for two reasons. 1, for kdist_image, kdist_clean is invoked as root in kdist_build before it is invoked again as normal-user back in kdist_image. 2, the examples in the HOWTO-DEVEL.gz (and elsewhere as comments in the Makefiles) require that the kdist_clean target be run as root (e.g. ndiswrapper follows the examples quite closely).
I have included a very simple patch that adds $(ROOT_CMD) to the call to rules kdist_clean. It seems to solve the problem, hope it helps. Kevin -- System Information: Debian Release: 3.1 APT prefers testing APT policy: (990, 'testing'), (500, 'unstable') Architecture: i386 (i686) Kernel: Linux 2.6.10.20050403a Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Versions of packages module-assistant depends on: ii perl 5.8.4-8 Larry Wall's Practical Extraction -- no debconf information
--- common-rules.mk 2005-04-08 23:34:14.390821576 -0400 +++ common-rules.mk.new 2005-04-08 23:35:34.157695168 -0400 @@ -48,7 +48,7 @@ # seperate binary-modules target to make testing the package building # easier, and kdist_build is the rule used by both, kdist and kdist_image kdist_image: kdist_build - $(MAKE) $(MFLAGS) -f debian/rules kdist_clean + $(ROOT_CMD) $(MAKE) $(MFLAGS) -f debian/rules kdist_clean # common build rule for modules ifdef ROOT_CMD
