Hi, On Tue, May 22, 2007, Niv Sardi wrote: > > On Tue, May 22, 2007, Sven Arvidsson wrote: > >> Confirming and merging the two reports about this. > >> @pkg-gnome, would the attached patch be okay? > > > > Looks good; please commit. > > No it doesn't it doesn't solve the issue that we should try to see witch > ubuntu version is incriminated, and I don't personally feel we should > have ubuntu-bugs patching code in our release, I'm considering top drop > that check.
There are two or three things here: - one is that a preinst snippet was added to stop older system-tools-backends, presumably due to some packaging mistake before 2.1.0-0ubuntu2 - the other is that this also matches upgrades from non "/etc/dbus-1/event.d/70system-tools-backends" aware versions of system-tools-backends, but shouldn't - the version check was tweaked when applied to Debian, but this was incorrect -- this changed was reversed too So while I agree that you could drop the preinst entirely, it would make merging your package against the Ubuntu one or the contrary harder. The proposed fix seems like the correct fix for the bogus preinst that we currently have; it's bogus because it doesn't handle upgrades from packages which are lacking /etc/dbus-1/event.d/70system-tools-backends, such as the 1.4 versions. Bye, -- Loïc Minier
