Bug#424912: lircd is started although START_LIRCMD=false is in /etc/lirc/hardware.conf

[Achim Lobbert]

Package: lirc
Version: 0.8.0-9.2
Severity: normal
Tags: patch

File /etc/lirc/hardware.conf contains an entry to disable starting of lirc:

    #Don't start lircmd even if there seems to be a good config file
    START_LIRCMD=false

but even when uncommenting the 'START_LIRCMD=false' lircd starts because
of a small error in /etc/init.d/lirc . The following conditional 

    if $START_LIRCD; then

is incorrect and should be corrected to

    if [ "$START_LIRCD" == "true" ]; then

The attached patch should correct this minor issue.

Achim


-- System Information:
Debian Release: lenny/sid
  APT prefers stable
  APT policy: (1000, 'stable'), (800, 'stable'), (90, 'unstable'), (80, 
'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.18 (PREEMPT)
Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=ISO-8859-15)
Shell: /bin/sh linked to /bin/bash

Versions of packages lirc depends on:
ii  debconf [debconf-2.0]     1.5.13         Debian configuration management sy
ii  dialog                    1.1-20070325-1 Displays user-friendly dialog boxe
ii  libasound2                1.0.13-2       ALSA library
ii  libc6                     2.3.6.ds1-13   GNU C Library: Shared libraries
ii  liblircclient0            0.8.0-9.2      LIRC client library
ii  libusb-0.1-4              2:0.1.12-6     userspace USB programming library

lirc recommends no packages.

-- debconf information:
  lirc/take_care_of_old_config:
* lirc/install_devices: false
* lirc/reconfigure: false
  lirc/lircmd_conf: hauppauge/lircmd.conf.hauppauge
  lirc/remove_var-log-lircd: true
  lirc/driver: default
  lirc/should-use-IntelliMouse:
  lirc/cflags: -DLIRC_SERIAL_SOFTCARRIER
  lirc/irq: none
  lirc/lircd_conf: hauppauge/lircd.conf.hauppauge
  lirc/port: none
  lirc/device: /dev/lirc
  lirc/timer: 65536
  lirc/modules: lirc_dev

--- lirc.orig   2007-02-18 12:48:27.000000000 +0100
+++ lirc        2007-05-17 20:47:32.000000000 +0200
@@ -94,13 +94,13 @@ case "$1" in
        load_modules $MODULES
     fi
     echo -n "Starting lirc daemon:"
-    if $START_LIRCD; then
+    if [ "$START_LIRCD" = "true" ]; then
       echo -n " lircd"
       LIRCD_ARGS=`build_args $LIRCD_ARGS`
       start-stop-daemon --start --quiet --exec /usr/sbin/lircd -- $LIRCD_ARGS \
                < /dev/null
     fi
-    if $START_LIRCMD; then
+    if [ "$START_LIRCD" = "true" ]; then
       echo -n " lircmd"
       start-stop-daemon --start --quiet --exec /usr/sbin/lircmd \
                < /dev/null
@@ -116,7 +116,7 @@ case "$1" in
     echo "."
     ;;
   reload|force-reload)
-    if $START_LIRCD; then
+    if [ "$START_LIRCD" = "true" ]; then
       start-stop-daemon --stop --quiet --signal 1 --exec /usr/sbin/lircd
     fi
     if $START_LIRCMD; then