On Tue, May 08, 2007 at 12:58:11PM +0200, Aur??lien G??R??ME wrote: > On Tue, May 08, 2007 at 08:09:40AM +0000, Gerrit Pape wrote: > >On Thu, May 03, 2007 at 08:30:23PM +0200, Aur??lien G??R??ME wrote: > >> I completely fail to see why git-daemon-run depends on runit which > >> is a replacement of sysvinit. Please remove that package from the > >> Depends field. This bug appears in both Etch and Sid. > > > >Hi, this doesn't make sense, the whole and single purpose of the > >git-daemon-run package is to provide a runit service. Try dpkg -L > >git-daemon-run. The git-daemon program itself is in the git-core > >package. > > Well, AFAICT, git-daemon-run can also be run either as a standalone > service from an /etc/init.d script or as an inetd/xinetd service.
Yes, sure, git-daemon can be started through an init script, or through inetd. But that's not how I personally want it to be run, I prefer runit managed services for convenience and reliability. > >> I set the severity to important, because this bug leaves the package > >> in an unconfigured state inside a vserver context. Precisely, the > >> postinst maintainer script of runit fails to send a SIGHUP to init, > >> because sysvinit is not used inside a vserver context, so there is > >> no need to reread /etc/inittab. > >> > >> We might believe that it is a runit bug, but runit is fully > > > >It might be a bug in the runit Debian package, yes. > > It is actually the "kill -HUP 1" in the postinst of git-daemon-run > which is at fault. Yes, I heard of this before, and was surprised to see a unix system without a pid no 1. I personally don't have access to a debian vserver, so I didn't 'fix' it yet. > >> useless inside a vserver context, so nobody would install such a > >> software. Unfortunately, git-daemon-run installs it by the dependency > >> mechanism. > > > >Ups, it's useless inside a vserver context?, I didn't know about that, > >that would be another bug in the runit Debian package then. > > As a matter of fact, I did not know runit before I setup my git > server and I was quite surprised that the git-daemon-run official > Debian package would not be setup to run either as standalone or as > an inetd/xinetd service. > > Maybe would it be possible to switch it to a standalone server? I can > provide you a patch and a debconf question to do that, i.e. either > the actual behaviour with runit or a standalone server. Please tell > me your thoughts about it. :] I do prefer it the way it is. If the runit package would have installed okay for you (outside vserver), you probably wouldn't have noticed. I'll think about providing /etc/init.d/git-daemon, so that you can control the service just like others that are started through init scripts. See /usr/share/doc/git-core/README.Debian and the sv(8) man page if you are interested. Thanks, Gerrit. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
