Package: bacula-director-mysql Version: 1.36.2-1 Severity: important The variable $MYSQL_PSWD_STRING was not quoted, with the result being that passwords containing spaces are treated as multiple arguments rather than a single password argument.
-davidc -- System Information: Debian Release: 3.1 APT prefers testing APT policy: (500, 'testing') Architecture: i386 (i686) Kernel: Linux 2.6.8-1-386 Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) Versions of packages bacula-director-mysql depends on: ii bacula-common 1.36.2-1 Network backup, recovery and verif ii bacula-director-common 1.36.2-1 Network backup, recovery and verif ii debconf 1.4.30.11 Debian configuration management sy ii libc6 2.3.2.ds1-20 GNU C Library: Shared libraries an ii libgcc1 1:3.4.3-12 GCC support library ii libmysqlclient10 3.23.56-2 LGPL-licensed client library for M ii libssl0.9.7 0.9.7e-3 SSL shared libraries ii libstdc++5 1:3.3.5-8 The GNU Standard C++ Library v3 ii libwrap0 7.6.dbs-8 Wietse Venema's TCP wrappers libra ii mysql-client 4.0.24-2 mysql database client binaries ii zlib1g 1:1.2.2-3 compression library - runtime -- debconf information: * bacula-director-mysql/db_host: localhost * bacula-director-mysql/remove_catalog_on_purge: false * bacula-director-mysql/create_tables: true * bacula-director-mysql/mysql_root_username: root * bacula-director-mysql/db_user: bacula
--- bacula-director-mysql.postinst.orig 2005-04-04 15:30:05.341647000 -0400 +++ bacula-director-mysql.postinst 2005-04-04 15:33:06.399723811 -0400 @@ -67,7 +67,11 @@ fi echo -n "Checking DB connectivity..." - if ! $MYSQLADMIN $MYSQL_HOST_STRING -u $MYSQL_ROOT_USER $MYSQL_PSWD_STRING ping >/dev/null 2>&1 + + # debug + echo $MYSQLADMIN $MYSQL_HOST_STRING -u $MYSQL_ROOT_USER "$MYSQL_PSWD_STRING" ping '>/dev/null 2>&1' + + if ! $MYSQLADMIN $MYSQL_HOST_STRING -u $MYSQL_ROOT_USER "$MYSQL_PSWD_STRING" ping >/dev/null 2>&1 then echo -e "\nERROR: Could not connect to MySQL server at $MYSQL_HOST" exit 1 @@ -78,14 +82,14 @@ if [ "$RET" = "true" ]; then # Create DB echo -n "Creating Catalog \"$CATALOG\" ..." - $MYSQLADMIN $MYSQL_HOST_STRING -u $MYSQL_ROOT_USER $MYSQL_PSWD_STRING \ + $MYSQLADMIN $MYSQL_HOST_STRING -u $MYSQL_ROOT_USER "$MYSQL_PSWD_STRING" \ create $CATALOG >/dev/null 2>&1 || true echo "Ok." # Create tables echo -n "Creating tables ..." if ! $MAKE_SQL_TABLES $MYSQL_HOST_STRING \ - -u $MYSQL_ROOT_USER $MYSQL_PSWD_STRING >/dev/null 2>&1 + -u $MYSQL_ROOT_USER "$MYSQL_PSWD_STRING" >/dev/null 2>&1 then echo -e "\nERROR: Table creation failed!" exit 1 @@ -112,7 +116,7 @@ echo -e "GRANT ALL privileges ON $CATALOG.* TO [EMAIL PROTECTED] " \ "$MYSQL_USER_PSWD_STRING;\nFLUSH PRIVILEGES;" \ - | $MYSQL -h $MYSQL_HOST -u $MYSQL_ROOT_USER $MYSQL_PSWD_STRING mysql + | $MYSQL -h $MYSQL_HOST -u $MYSQL_ROOT_USER "$MYSQL_PSWD_STRING" mysql fi # bacula-director-mysql/create_tables == "true" @@ -125,7 +129,7 @@ # patched upgrade script to use additional arguments on connection echo -n "Upgrading Catalog to v7 ..." if ! ${UPGRADE_SQL_DIR}/$UPGRADE_TABLES1 $MYSQL_HOST_STRING \ - -u $MYSQL_ROOT_USER $MYSQL_PSWD_STRING > $LOGDIR/upgrade.log 2>&1 + -u $MYSQL_ROOT_USER "$MYSQL_PSWD_STRING" > $LOGDIR/upgrade.log 2>&1 then echo -e "\nERROR: Catalog upgrading failed! Check $LOGDIR/upgrade.log for details." exit 1 @@ -138,7 +142,7 @@ # patched upgrade script to use additional arguments on connection echo -n "Upgrading Catalog to v8 ..." if ! ${UPGRADE_SQL_DIR}/$UPGRADE_TABLES2 $MYSQL_HOST_STRING \ - -u $MYSQL_ROOT_USER $MYSQL_PSWD_STRING > $LOGDIR/upgrade.log 2>&1 + -u $MYSQL_ROOT_USER "$MYSQL_PSWD_STRING" > $LOGDIR/upgrade.log 2>&1 then echo -e "\nERROR: Catalog upgrading failed! Check $LOGDIR/upgrade.log for details." exit 1