Package: xchat
Version: 2.4.1-0.1
Severity: normal
Tags: upstream patch

XChat 2.4.x has a bug that prevents input method activation after switching
tabs.  The user has to minimize the window and restore it again to use input
method (to input Chinese, for example) as a workaround, and this is very
annoying.

The bug is submitted upstream
(http://sourceforge.net/tracker/index.php?func=detail&aid=1168239&group_id=239&atid=100239),
and after discussion a two-line patch is accepted by upstream.  The patch is
very simple, it uses GTK+ function to set gtkentry properties instead of setting
the variable directly. It can be seen at
http://cvs.sourceforge.net/viewcvs.py/xchat/xchat2/src/fe-gtk/maingui.c?r1=1.113&r2=1.114
in upstream CVS.  I am also attaching the patch.

This is a regression from xchat 2.0 (therefore regression from warty), it makes
xchat quite unusable for Chinese users.  The patch is simple and already
accepted upstream.  It would be nice to have it in sarge (but now looking at
the NMU history, I am not that optimistic).

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.8-2-k7
Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages xchat depends on:
ii  libatk1.0-0          1.8.0-4             The ATK accessibility toolkit
ii  libc6                2.3.2.ds1-20        GNU C Library: Shared libraries an
ii  libglib2.0-0         2.6.3-1             The GLib library of C routines
ii  libgtk2.0-0          2.6.2-4             The GTK+ graphical user interface 
ii  libpango1.0-0        1.8.1-1             Layout and rendering of internatio
ii  libperl5.8           5.8.4-8             Shared Perl library
ii  libssl0.9.7          0.9.7e-3            SSL shared libraries
ii  libx11-6             4.3.0.dfsg.1-12.0.1 X Window System protocol client li
ii  python2.3            2.3.5-2             An interactive high-level object-o
ii  tcl8.4               8.4.9-1             Tcl (the Tool Command Language) v8
ii  xchat-common         2.4.1-0.1           Common files for X-Chat
ii  xlibs                4.3.0.dfsg.1-12     X Keyboard Extension (XKB) configu

-- no debconf information
===================================================================
RCS file: /cvsroot/xchat/xchat2/src/fe-gtk/maingui.c,v
retrieving revision 1.113
retrieving revision 1.114
diff -u -r1.113 -r1.114
--- xchat/xchat2/src/fe-gtk/maingui.c	2005/03/11 06:37:52	1.113
+++ xchat/xchat2/src/fe-gtk/maingui.c	2005/03/30 05:36:40	1.114
@@ -421,7 +421,7 @@
 	/* dirty trick to avoid auto-selection */
 	GTK_ENTRY (sess->gui->input_box)->editable = 0;
 	gtk_widget_grab_focus (sess->gui->input_box);
-	GTK_ENTRY (sess->gui->input_box)->editable = 1;
+	gtk_editable_set_editable (GTK_EDITABLE (sess->gui->input_box), TRUE);
 
 	sess->server->front_session = sess;
 
@@ -1639,7 +1639,7 @@
 	/* dirty trick to avoid auto-selection */
 	GTK_ENTRY (current_sess->gui->input_box)->editable = 0;
 	gtk_widget_grab_focus (current_sess->gui->input_box);
-	GTK_ENTRY (current_sess->gui->input_box)->editable = 1;
+	gtk_editable_set_editable (GTK_EDITABLE (current_sess->gui->input_box), TRUE);
 }
 
 static void

Reply via email to