Hi,
On Sun, Apr 01, 2007, Marc-André Lureau wrote:
> I made some changes based on the comments of Loic. Thanks again for your
> helpful review. I hope you can upload vala soon.
Err, you started from a fully different package and you attached the
diff against another upstream version! This doesn't ease review to say
the least.
I don't understand exactly why you're sending me a diff where
Mathias Hasselmann is the maintainer.
Marc-André, Mathias: who is going to maintain the package for Debian?
Marc-André or Mathias, I will need to know where you downloaded
Mathias' packaging from and/or under which license the packaging by
Mathias is.
Marc-André, there are plenty of problems with the second diff you sent
me and we're going backwards since my last review: the ITP isn't closed
by your changelog, you're not listed as maintainer, the copyright is
incomplete (it doesn't have the license block), config.guess and .sub
are not updated automatically anymore, there are missing
build-dependencies, etc.
Bye,
--
Loïc Minier
