On Fri, Mar 30, 2007 at 11:29:00AM +0200, Guus Sliepen wrote:
> package ekiga
> severity 415731 serious
> merge 416634 415731
> thanks
> After some debugging, I found out that it crashed because it tried to
> display a warning message about the camera not being found, which was
> broken because of the reason mentioned in bug #415731. On i386, this
> apparently does not trigger a segfault or maybe not often, but on amd64
> it always crashes (probably because amd64 uses a different way to store
> varargs).
Indeed, this behavior should never cause a segfault on i386, but will cause
the problems seen on amd64 because of differences in how varargs are
represented.
The upstream description of the bug and requisite fix looks accurate to me,
though there is no explicit patch in the bug log, so please find one
attached. I have no immediate plans to NMU this since I don't have the
means to reproduce the original bug myself and prove that it's completely
fixed (just starting ekiga on amd64 isn't enough to trigger any problems,
but feel free to call sip:[EMAIL PROTECTED] for a test :), but if no one else
is available to work on this I can NMU Monday or so to get this fixed for
etch.
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
[EMAIL PROTECTED] http://www.debian.org/
diff -u ekiga-2.0.3/debian/control ekiga-2.0.3/debian/control
--- ekiga-2.0.3/debian/control
+++ ekiga-2.0.3/debian/control
@@ -2,7 +2,7 @@
Section: gnome
Priority: optional
Maintainer: Kilian Krause <[EMAIL PROTECTED]>
-Uploaders: Jose Carlos Garcia Sogo <[EMAIL PROTECTED]>, Debian GNOME Maintainers <[EMAIL PROTECTED]>, Andrew Lau <[EMAIL PROTECTED]>, Clément Stenac <[EMAIL PROTECTED]>, Dafydd Harries <[EMAIL PROTECTED]>, Guilherme de S. Pastore <[EMAIL PROTECTED]>, Gustavo Franco <[EMAIL PROTECTED]>, Gustavo Noronha Silva <[EMAIL PROTECTED]>, J.H.M. Dassen (Ray) <[EMAIL PROTECTED]>, Jordi Mallach <[EMAIL PROTECTED]>, Jose Carlos Garcia Sogo <[EMAIL PROTECTED]>, Josselin Mouette <[EMAIL PROTECTED]>, Loic Minier <[EMAIL PROTECTED]>, Marc 'HE' Brockschmidt <[EMAIL PROTECTED]>, Marco Cabizza <[EMAIL PROTECTED]>, Oystein Gisnas <[EMAIL PROTECTED]>, Ondřej Surý <[EMAIL PROTECTED]>, Ross Burton <[EMAIL PROTECTED]>, Sebastien Bacher <[EMAIL PROTECTED]>, Sjoerd Simons <[EMAIL PROTECTED]>
+Uploaders: Jose Carlos Garcia Sogo <[EMAIL PROTECTED]>, Debian GNOME Maintainers <[EMAIL PROTECTED]>, Loic Minier <[EMAIL PROTECTED]>
Build-Depends: debhelper (>= 4.1.34), gettext, libgnome2-dev, libldap2-dev, libpt-dev (>= 1.10.2-2), libopal-dev (>= 2.2.3.dfsg-2), libgconf2-dev, libgnomeui-dev, libsdl1.2-dev, dpatch, autotools-dev, gnome-pkg-tools, scrollkeeper, automake1.7, intltool, libxml-parser-perl, evolution-data-server-dev, gnome-doc-utils, libavahi-client-dev (>= 0.6.0), libavahi-glib-dev (>= 0.6.0), libebook1.2-dev
Standards-Version: 3.7.2
diff -u ekiga-2.0.3/debian/changelog ekiga-2.0.3/debian/changelog
--- ekiga-2.0.3/debian/changelog
+++ ekiga-2.0.3/debian/changelog
@@ -1,3 +1,14 @@
+ekiga (2.0.3-5.1) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * High-urgency upload for RC bugfix.
+ * Take care not to reuse a single va_list for multiple calls to
+ vsnprintf(), the list should be released and re-created between
+ invocations for portability; fixes a segfault on amd64.
+ Closes: #415731.
+
+ -- Steve Langasek <[EMAIL PROTECTED]> Fri, 30 Mar 2007 03:31:34 -0700
+
ekiga (2.0.3-5) unstable; urgency=high
* SECURITY: New dpatch, 51_fix-format-strings, supersedes dpatch
only in patch2:
unchanged:
--- ekiga-2.0.3.orig/lib/gui/gmdialog.c
+++ ekiga-2.0.3/lib/gui/gmdialog.c
@@ -468,6 +468,10 @@
vsnprintf (buffer, 1024, format, args);
+ va_end (args);
+
+ va_start (args, format);
+
prim_text =
g_strdup_printf ("<span weight=\"bold\" size=\"larger\">%s</span>",
primary_text);
