Package: xmms2
Version: 0.2DrHouse-3.1
Severity: important
Tags: patch

Hi,

your package isn't buildable at the moment on GNU/kFreeBSD since it has
some Linux-specific B-D:
 - libasound2-dev
 - libraw1394-dev
 - libdc1394-dev

Please find attached a patch to conditionalize those to not required on
kfreebsd-{i386,amd64}.

Then, it is needed to change xmms2-plugin-alsa from "Architecture: any"
to "Architecture: linux-any", which is not possible at the moment, since
"linux-any" isn't supported (yet) in the whole archive (though I don't
know exactly what the blockers are). That's why I'm suggesting a list of
Linux arch's, i.e. the "official" ones (including m68k, that's not a
troll ;-)), plus armeb and armel, following Julien Cristau's suggestion.

And the last tweak needed in the control file is to make the Depends: on
xmms2-plugin-alsa conditional, for xmms2.


Moving to the build itself, xmmsenv.py has to be tweaked a bit to
support GNU/kFreeBSD.


Then, the rules files has to be adapted a bit, to reflect the fact that
we are not building all (-a) packages but only all packages for this
particular architectures (-s) [these options are documented in
debhelper(7)]. I only proposed in my diff the change (-a to -s) where it
is absolutely needed, but I guess that it would be better to turn all -a
to -s.


At last, I don't really know about the status of the sound on GNU/Hurd,
but you might want to tweak Architecture-related packages once for all,
so you might want to add hurd-i386 along with kfreebsd-{i386,amd64}, and
use startswidth('gnu') instead of starswidth('gnukfreebsd') in my diff
against xmmsenv.py, to get your package a chance to be built on this
platform.

[GNU/Linux is 'linux', GNU/kFreeBSD is 'gnukfreebsd', I guess that
GNU/Hurd is 'gnu', or maybe 'gnuhurd', so a test on gnu* should be good
enough.]

I know this is quite a long mail, but after that, xmms2 builds fine on
GNU/kFreeBSD, along with esperanza and nyello (gxmms2 needs gkrellm,
that we don't have, at least right now).

Thanks for your attention.

Cheers,

-- 
Cyril Brulebois

PS: If you want me to test the build of an upload candidate, please drop
    me a line, I'll try it as soon as possible, so that you're sure that
        your package builds fine before uploading.
--- xmms2-0.2DrHouse/debian/control     2007-03-27 04:10:08.457117000 +0200
+++ xmms2-0.2DrHouse/debian/control     2007-03-27 04:42:26.000000000 +0200
@@ -4,12 +4,12 @@
 Maintainer: Florian Ragwitz <[EMAIL PROTECTED]>
 Uploaders: Jens Taprogge <[EMAIL PROTECTED]>, Jonne Lehtinen <[EMAIL 
PROTECTED]>
 Standards-Version: 3.7.2
-Build-Depends: debhelper (>= 5.0.37.2), dpatch, scons, libsqlite3-dev, ruby, 
ruby1.8-dev, python, python-dev, libglib2.0-dev, libcurl3-dev, 
libsmbclient-dev, libgnomevfs2-dev, libvorbis-dev, libshout-dev, libflac-dev, 
libmodplug-dev, libmad0-dev, libasound2-dev, libjack-dev, libavahi-client-dev, 
libgamin-dev, libmpcdec-dev, libmms-dev, libsidplay2-dev, libresid-builder-dev, 
libavformat-dev, libraw1394-dev, libdc1394-dev, libboost-dev, 
libboost-signals-dev, python-support (>= 0.3), python-pyrex, fftw3-dev, 
libsamplerate-dev, libao-dev
+Build-Depends: debhelper (>= 5.0.37.2), dpatch, scons, libsqlite3-dev, ruby, 
ruby1.8-dev, python, python-dev, libglib2.0-dev, libcurl3-dev, 
libsmbclient-dev, libgnomevfs2-dev, libvorbis-dev, libshout-dev, libflac-dev, 
libmodplug-dev, libmad0-dev, libasound2-dev [!kfreebsd-i386 !kfreebsd-amd64], 
libjack-dev, libavahi-client-dev, libgamin-dev, libmpcdec-dev, libmms-dev, 
libsidplay2-dev, libresid-builder-dev, libavformat-dev, libraw1394-dev 
[!kfreebsd-i386 !kfreebsd-amd64], libdc1394-dev [!kfreebsd-i386 
!kfreebsd-amd64], libboost-dev, libboost-signals-dev, python-support (>= 0.3), 
python-pyrex, fftw3-dev, libsamplerate-dev, libao-dev
 XS-Python-Version: 2.4
 
 Package: xmms2
 Architecture: all
-Depends: xmms2-core, xmms2-client-cli, xmms2-plugin-vorbis, xmms2-plugin-mad, 
xmms2-plugin-id3v2, xmms2-plugin-alsa
+Depends: xmms2-core, xmms2-client-cli, xmms2-plugin-vorbis, xmms2-plugin-mad, 
xmms2-plugin-id3v2, xmms2-plugin-alsa [!kfreebsd-i386 !kfreebsd-amd64]
 Conflicts: xmms2-plugin-nulstripper
 Replaces: xmms2-plugin-nulstipper
 Description: Client/server based media player system
@@ -310,7 +310,7 @@
  This package enables OSS output for xmms2.
 
 Package: xmms2-plugin-alsa
-Architecture: any
+Architecture: alpha amd64 arm armeb armel hppa i386 ia64 m32r m68k mips mipsel 
powerpc s390 sparc
 Depends: xmms2-core (= ${Source-Version}), ${shlibs:Depends}, ${misc:Depends}
 Enhances: xmms2-core
 Description: XMMS2 - ALSA output
--- xmms2-0.2DrHouse/xmmsenv.py 2007-03-27 04:05:08.826102000 +0200
+++ xmms2-0.2DrHouse/xmmsenv.py 2007-03-27 04:06:35.000000000 +0200
@@ -146,6 +146,8 @@
 
                if sys.platform == 'linux2':
                        self.platform = 'linux'
+               elif sys.platform.startswith("gnukfreebsd"):
+                       self.platform = 'linux'
                elif sys.platform.startswith("freebsd"):
                        self.platform = 'freebsd'
                elif sys.platform.startswith("openbsd"):
--- xmms2-0.2DrHouse/debian/rules       2007-03-27 04:51:56.062134000 +0200
+++ xmms2-0.2DrHouse/debian/rules       2007-03-27 05:08:39.000000000 +0200
@@ -34,7 +34,7 @@
        dh_testroot
        dh_clean -k
        scons $(SCONSFLAGS) INSTALLDIR="`pwd`/debian/tmp/" install
-       dh_install --sourcedir=debian/tmp --list-missing
+       dh_install -s --sourcedir=debian/tmp --list-missing
        touch install-stamp
 
 binary-indep: build install
@@ -63,9 +63,9 @@
        dh_python -a -ppython-xmmsclient
        dh_installdeb -a
        dh_shlibdeps -a -Llibxmmsclient0 -Llibxmmsclient-glib0 
-Llibxmmsclient++0 -Llibxmmsclient++-glib0 -ldebian/tmp/usr/lib
-       dh_gencontrol -a
+       dh_gencontrol -s
        dh_md5sums -a
-       dh_builddeb -a
+       dh_builddeb -s
 
 patch: patch-stamp
 patch-stamp:

Reply via email to