Jonas, Good catch! Those cron lines are running in my system now, but are they working? I just checked, and they aren't! I'll fix them on my system. I'm fairly new to Linux, so I'm glad that you guys checked my documentation patch for accuracy. I hadn't considered non-bash sh variants either. I think you are right, that last bit about cron should just be dropped from my addition to the readme file. A comment to explain why this isn't the default, as you suggest, is certainly a good idea too, +1 from me.
Thanks for all your work! --- Eric Wadsworth Jonas Smedegaard wrote: > Charles Fry wrote: > > > Unless I hear objections from the other awstats maintainers, I'll apply > > your patch. > > Excellent text, Eric! > > I have one comment, though: That cron line you suggest at the end - did > you actually test that it works? It seems odd to me - a [ -x ] test > should only check if a file has the executable bit set, not actually > execute it. And if it works for you, then also make sure that it works > with non-bash sh variants! > > Perhaps advertise the example script for multiple domains. > > Perhaps mention why it isn't the default: The package cannot safely > handle upgrades to locally added config files - if config options change > then the main file is updated (with warnings if edited locally) but > extra config files are silently ignored and possibly broken. > > > > But all the above suggestions are just nice additions - if you disagree > or if you don't understand my points, then just consider dropping your > concrete example for a cron entry... > > > - Jonas > -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
