Hello! On Sat, 10 Mar 2007 22:14:49 +0100, Richard B. Kreckel wrote:
> I've only one question: Is there a reason why you are removeing > @CPPFLAGS@ from CFlags in the patch above? Yes. @CPPFLAGS@ contains preprocessor flags which are necessary to build CLN itself. For a package using CLN these flags are not necessary or even harmful (e.g. -DNO_ASM). The only information it needs is location of the CLN headers. > I'm not yet entirely confident that it is a good idea to drop > cln-config entirely. It has problems, true, but it might be needed > by someone? The main "user" of cln-config was^W is cln.m4 (AC_PATH_CLN). I think it is safe to delete both. Some projects out of there will need to update their configure.{ac,in}: replace AC_PATH_CLN(version) with PKG_CHECK_MODULES(CLN, version). If there will be some prominent note in the ChangeLog (or NEWS), this is not a big deal. Moreover, PKG_CHECK_MODULES(MYAPP, cln >= 1.1.10 foo >= 0.0.1 bar >= 1.2.3) dnl no need to guess how the variables called: they are MYAPP_LIBS dnl and MYAPP_CFLAGS (cf. CLN_LIBS versus GINACLIB_LIBS) is more convenient and less error-prone then AC_PATH_CLN(1.1.10, [], [AC_MSG_ERROR("No CLN vers. >= 1.1.10 can be found")]) AM_PATH_FOO(0.0.1, [], [AC_MSG_ERROR("No foo vers. >= 0.0.1 can be found")]) AX_PATH_BAR(0.0.1, [], [AC_MSG_ERROR("No boo vers. >= 0.0.1 can be found")]) MYAPP_LIBS="$CLN_LIBS $FOO_LIBS $BAR_LIBS" MYAPP_CFLAGS="$CLN_CPPFLAGS $FOO_CFLAGS $CLFAGS_BAR" AC_SUBST(MYAPP_LIBS) AC_SUBST(MYAPP_CFLAGS) [PATCH] NEWS: mention cln-config and AC_PATH_CLN removal. --- NEWS | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 4d7468d..98866ff 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,8 @@ +========================== + +* cln-config and AC_PATH_CLN are gone, pkg-config(1) and PKG_CHECK_MODULES + should be used instead. See the CLN manual for more details. + 2006-08-08, version 1.1.13 ========================== -- 1.4.4.4 Best regards, Alexei -- All science is either physics or stamp collecting.
signature.asc
Description: Digital signature