severity 302200 normal
tags 302200 +pending +patch
thanks
On Wed, Mar 30, 2005 at 06:06:28PM +0200, Michael Vistein wrote:
> Package: e2fsprogs
> Version: 1.37-1
> Severity: grave
> Justification: renders package unusable
This is a problem only on IA64, and only breaks mke2fs, and not the
other e2fsprogs programs. The problem seems to be the malloc() goes
wonky if we don't include stdlib.h. The following patch fixes the
problem. I'll upload a fixed set of sources very shortly.
- Ted
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2005/03/31 00:01:33-05:00 [EMAIL PROTECTED]
# ostype.c (e2p_os2string): Check to make sure malloc() is
# successful before attempting to copy into it. Add
# #include of stdlib.h to fix a core dump bug on the IA64
# architecture. (Addresses Debian Bug #302200)
#
# lib/e2p/ostype.c
# 2005/03/31 00:01:33-05:00 [EMAIL PROTECTED] +3 -1
# ostype.c (e2p_os2string): Check to make sure malloc() is
# successful before attempting to copy into it. Add
# #include of stdlib.h to fix a core dump bug on the IA64
# architecture. (Addresses Debian Bug #302200)
#
# lib/e2p/ChangeLog
# 2005/03/31 00:01:33-05:00 [EMAIL PROTECTED] +7 -0
# Update log
#
diff -Nru a/lib/e2p/ChangeLog b/lib/e2p/ChangeLog
--- a/lib/e2p/ChangeLog 2005-03-31 00:01:46 -05:00
+++ b/lib/e2p/ChangeLog 2005-03-31 00:01:46 -05:00
@@ -1,3 +1,10 @@
+2005-03-30 Theodore Ts'o <[EMAIL PROTECTED]>
+
+ * ostype.c (e2p_os2string): Check to make sure malloc() is
+ successful before attempting to copy into it. Add
+ #include of stdlib.h to fix a core dump bug on the IA64
+ architecture. (Addresses Debian Bug #302200)
+
2005-03-21 Theodore Ts'o <[EMAIL PROTECTED]>
* Release of E2fsprogs 1.37
diff -Nru a/lib/e2p/ostype.c b/lib/e2p/ostype.c
--- a/lib/e2p/ostype.c 2005-03-31 00:01:46 -05:00
+++ b/lib/e2p/ostype.c 2005-03-31 00:01:46 -05:00
@@ -9,6 +9,7 @@
#include "e2p.h"
#include <string.h>
+#include <stdlib.h>
const char *os_tab[] =
{ "Linux",
@@ -32,7 +33,8 @@
os = "(unknown os)";
ret = malloc(strlen(os)+1);
- strcpy(ret, os);
+ if (ret)
+ strcpy(ret, os);
return ret;
}
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
