Package: lx-gdb Severity: important Tags: patch Hi,
currently your package FTBFS on GNU/kFreeBSD with the following error: > cc -Wall -O2 -Wstrict-prototypes gdbload.c -o gdbload > gdbload.c: In function 'readLine': > gdbload.c:565: warning: pointer targets in passing argument 1 of 'strlen' > differ in signedness > gdbload.c:565: warning: pointer targets in passing argument 1 of '__strdup' > differ in signedness > gdbload.c:635: warning: pointer targets in passing argument 1 of 'strlen' > differ in signedness > gdbload.c:635: warning: pointer targets in passing argument 1 of '__strdup' > differ in signedness > gdbload.c: In function 'matchField': > gdbload.c:667: warning: implicit declaration of function 'stricmp' > gdbload.c: In function 'addCategories': > gdbload.c:766: warning: suggest explicit braces to avoid ambiguous 'else' > /tmp/ccJLMMuU.o: In function `matchField': > gdbload.c:(.text+0x83e): undefined reference to `stricmp' > collect2: ld returned 1 exit status > make[1]: *** [gdbload] Error 1 > make[1]: Leaving directory `/build/buildd/lx-gdb-1.03' > make: *** [build-stamp] Error 2 Full build logs are available at <http://experimental.ftbfs.de/build.php?arch=kfreebsd-i386&pkg=lx-gdb>. Please find attached a tiny patch which adds a "|| defined(__GLIBC__)" which is the proper way to test whether we're using GNU libc (so you or upstream might want to rewrite the test a bit). Cheers, -- Cyril Brulebois
--- lx-gdb-1.03/gdbload.c 2007-03-09 08:15:48.042920000 +0100 +++ lx-gdb-1.03/gdbload.c 2007-03-09 08:16:02.000000000 +0100 @@ -76,7 +76,7 @@ /* This define is needed for HP-UX systems, and probably not anywhere else * I would guess. Comment it in if needed. */ -#if defined(__hpux) || defined(__linux__) || defined(__GNU__) +#if defined(__hpux) || defined(__linux__) || defined(__GNU__) || defined(__GLIBC__) #define stricmp strcasecmp #endif