Bug#411145: pipes don't work anymore

[Vincent Fourmond]

Package: dvdauthor
Version: 0.6.13-1
Severity: normal
Tags: patch


  Hello,

  Pipe opening doesn't work anymore with the recent version of
dvdauthor. I traced back the problems to the mode arguments in popen
(the author is using "rb" or "wb", but man 3 popen says only "w" or
"r"). The attached patch fixes it.

  Cheers,

    Vincent Fourmond, heavily depending on dvdauthor's pipe capacities...


-- System Information:
Debian Release: 4.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/dash
Kernel: Linux 2.6.18
Locale: LANG=en_GB, LC_CTYPE=en_GB (charmap=ISO-8859-1) (ignored: LC_ALL set to 
en_GB)

Versions of packages dvdauthor depends on:
ii  libbz2-1.0          1.0.3-6              high-quality block-sorting file co
ii  libc6               2.3.6.ds1-11         GNU C Library: Shared libraries
ii  libdvdread3         0.9.7-2              library for reading DVDs
ii  libfreetype6        2.2.1-5              FreeType 2 font engine, shared lib
ii  libice6             1:1.0.1-2            X11 Inter-Client Exchange library
ii  libjasper-1.701-1   1.701.0-2            The JasPer JPEG-2000 runtime libra
ii  libjpeg62           6b-13                The Independent JPEG Group's JPEG 
ii  liblcms1            1.15-1               Color management library
ii  libmagick9          7:6.2.4.5.dfsg1-0.14 Image manipulation library
ii  libpng12-0          1.2.15~beta5-1       PNG library - runtime
ii  libsm6              1:1.0.1-3            X11 Session Management library
ii  libtiff4            3.8.2-7              Tag Image File Format (TIFF) libra
ii  libx11-6            2:1.0.3-5            X11 client-side library
ii  libxext6            1:1.0.1-2            X11 miscellaneous extension librar
ii  libxml2             2.6.27.dfsg-1        GNOME XML library
ii  libxt6              1:1.0.2-2            X11 toolkit intrinsics library
ii  zlib1g              1:1.2.3-13           compression library - runtime

dvdauthor recommends no packages.

-- no debconf information

diff -Naur dvdauthor-0.6.13/src/compat.c dvdauthor-0.6.13.new/src/compat.c
--- dvdauthor-0.6.13/src/compat.c	2007-01-11 02:32:34.000000000 +0100
+++ dvdauthor-0.6.13.new/src/compat.c	2007-02-16 15:37:27.000000000 +0100
@@ -50,13 +50,13 @@
             char *fcopy=strdup(fname);
             fcopy[l-1]=0;
             vf.ftype=1;
-            vf.h=popen(fcopy,"rb");
+            vf.h=popen(fcopy,"r");
             free(fcopy);
             return vf;
         }
     } else if( fname[0]=='|' ) {
         vf.ftype=1;
-        vf.h=popen(fname+1,"wb");
+        vf.h=popen(fname+1,"w");
         return vf;
     }
     vf.ftype=0;