-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jari Aalto wrote: > Eddy Petrișor <[EMAIL PROTECTED]> writes: >> Have you done functional tests? >> Did you test with and without the option you added? >> Did you test with options that might have broken (options available for >> pieces of code that use the new options)? > > Yes. The option works as announced. > >> This is missing: >> * various cosmetic changes > > Added. > >>> + -h, --help Show the help message >>> + -N, --no-unrelease-tag Do not add word UNRELEASED to debian/changelog >> I'd say the option name choice is not quite inspired since it doesn't >> fall in line with the rest of the options. > > I've removed the short option from patch. We need to discuss about > options in genral separately. > > The option is now: > > --no-changelog-tag Do not set distribution to UNRELEASED in > debian/changelog > >> I think the changelog entry is a little misleading here: >> >>> + * svn-upgrade: Added option --verbose and --version. > > Corrected. >> I'd rather say: >> >> * reordered --verbose and --version options in help to appear towards >> the end (common practice) >> >> Or am I missing something? > > Actually we might want to reorder all options to be listed in > alphabetical order. It is common practice and scales to any number of > options.
IMHO, the best order is by scope and frequency of usage. Alphabetical order doesn't help the user in any way when is looking for an option whose name he/she doesn't know. > New patch attached. This is against SVN -r2340 2007-02-11 > Jari > > === modified file 'svn-buildpackage' > --- svn-buildpackage 2007-01-28 09:10:52 +0000 > +++ svn-buildpackage 2007-02-11 10:04:13 +0000 > @@ -20,24 +20,25 @@ > repository must be in the format created by svn-inject, and this script > must be executed from the work directory (trunk/package). > > - -h, --help Show the help message > - --svn-dont-clean Don't run debian/rules clean (default: clean first) > - --svn-dont-purge Don't wipe the build directory (default: purge after > build) > - --svn-no-links Don't use file links (default: use links where > possible) > - --svn-ignore-new Don't stop on svn conflicts or new/changed files > - --svn-verbose More verbose program output > - --svn-builder CMD Use CMD as build command instead of dpkg-buildpackage > - --svn-override a=b Override some config variable (comma separated list) > - --svn-move Move package files to .. after successful build > - --svn-move-to XYZ Move package files to XYZ, implies --svn-move > - --svn-only-tag Tags the current trunk directory without building > - --svn-tag Final build: Export && build && tag && dch -i > - --svn-retag Replace an existing tag directory if found while > tagging > - --svn-lintian Run lintian after the build. s/lintian/linda/ to use > linda > - --svn-pkg PACKAGE Specifies the package name > - --svn-export Just prepares the build directory and exits > - --svn-reuse Reuse an existing build directory, copy trunk over it > - --svn-noninteractive Turn off interactive mode > + -h, --help Show the help message > + --no-changelog-tag Do not set distribution to UNRELEASED in > debian/changelog ^^^^^^^^^^ this is *still* inconsistent with the rest of the options. See my proposed alternative names. Yes, I know they are long, but as I said they can be set in the .conf file. All the others, except for help (which is justified), start with --svn-. This doesn't. I am aware this parameter is also present in svn-upgrade's options and there isn't this de-facto convention, but I think svn-buildpackage is the most important of the two. > + --svn-dont-clean Don't run debian/rules clean (default: clean first) > + --svn-dont-purge Don't wipe the build directory (default: purge > after build) > + --svn-no-links Don't use file links (default: use links where > possible) > + --svn-ignore-new Don't stop on svn conflicts or new/changed files > + --svn-verbose More verbose program output > + --svn-builder CMD Use CMD as build command instead of > dpkg-buildpackage > + --svn-override a=b Override some config variable (comma separated list) > + --svn-move Move package files to .. after successful build > + --svn-move-to XYZ Move package files to XYZ, implies --svn-move > + --svn-only-tag Tags the current trunk directory without building > + --svn-tag Final build: Export && build && tag && dch -i > + --svn-retag Replace an existing tag directory if found while > tagging > + --svn-lintian Run lintian after the build. s/lintian/linda/ to > use linda > + --svn-pkg PACKAGE Specifies the package name > + --svn-export Just prepares the build directory and exits > + --svn-reuse Reuse an existing build directory, copy trunk over > it > + --svn-noninteractive Turn off interactive mode - -- Regards, EddyP ============================================= "Imagination is more important than knowledge" A.Einstein -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFF0MjaY8Chqv3NRNoRApmOAKDN0jIuazKnulrGit+lck2zqEkIWACfSV8Y miRUQSRya2uSc4CpqwxJHBg= =TTaK -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
