On Thu, Feb 08, 2007 at 02:47:00PM +0100, Bas Zoetekouw wrote:
> Hi Moritz!
>
> > I've upgraded my sid-based notebook last week and I'm running into
> > problems
> > caused by the charset fallback patch. I'm regularly using "x" to remove
> > all non-tagged read articles from the article list and slrn segfaults
> > every 5-7th time.
> > I suppose it's some kind of memory corruption. I don't have prior
> > experience with the slrn code base and lack the time to dig further
> > for the cause. Bas, could you have a look? I'd be happy to test patches.
>
> Hmm, that's weird, I thought my patch should work fine, at least valgrind
> showed no heap corruptions here. Could you try running valgrind
> --leak-check=full --show-reachable=yes on one of the session that crashes?
> That should give me some information about which variable is causing the
> corruption.
I've tracked it down to this hunk:
+#ifdef USE_ICONV /* we've copied this string */
+ slrn_free (h->from);
+#endif
This triggers a double free. With "slrn_free (h->from);" removed slrn works
w/o segfaults.
Cheers,
Moritz
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
