tags 409862 + wontfix

Hi Martin

Thanks for the bugreport.

On Tue, Feb 06, 2007 at 12:05:47AM +0000, Martin wrote:
> Package: vserver-debiantools
> Version: 0.3.4
> 
> A minor regression:
> 
> <quote>
> # newvserver --hostname x --domain example.com --ip 1.2.3.4 --dist sarge
> --mirror http://ftp.uk.debian.org/debian/ --vsroot /vserver/
> 
> newvserver error: --hostname must be a hostname for the vserver
> e.g. "alpha"
> </quote>
> 
> Line 235 has the regex
> 
> [a-z0-9]*([a-z0-9_-])[a-z0-9])
> 
> which looks a little odd to my eyes, perhaps:
> 
> [a-z0-9]*([a-z0-9_-]*)[a-z0-9]+)

No this is actually intentional. One can argue that a single
character is valid for a hostname, but it is not my view.
If you give me a good reason I can change my mind though.

However I think that the regex maybe should look like:
[a-z0-9]([a-z0-9_-]*)[a-z0-9])

Best reagrds,

// Ola

> 
> Cheers,
>  - Martin
> 
> 
> 
> 

-- 
 --------------------- Ola Lundqvist ---------------------------
/  [EMAIL PROTECTED]                     Annebergsslingan 37      \
|  [EMAIL PROTECTED]                     654 65 KARLSTAD          |
|  +46 (0)54-10 14 30                  +46 (0)70-332 1551       |
|  http://opalsys.net/                 UIN/icq: 4912500         |
\  gpg/f.p.: 7090 A92B 18FE 7994 0C36  4FE4 18A1 B1CF 0FE5 3DD9 /
 ---------------------------------------------------------------


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to