Gerrit Pape wrote: > On Tue, Jan 16, 2007 at 09:06:58PM -0800, Josh Triplett wrote: >> If you run git-log --pretty=foo, it fails with the message "fatal: invalid >> --pretty format: foo", but it still opens a pager displaying no content. > > Hmm, it doesn't for me, neither with 1.4.4.4, nor with 1.4.4.3, can you > please re-check?
I can still reproduce this. Investigating more carefully, I found two
different failure modes, depending on the way you invoke log. If you run
"git-log --pretty=foo", you get a pager containing the error message. This
seems wrong, because git-log should not open a pager containing a one-line
error message; it should just print the error message on stderr. If you run
"git log --pretty=foo" (note the space, rather than the dash), you get an
*empty* pager, and an error message at the terminal underneath the pager,
which you can see when you quit the pager. In both cases, git{-, }log should
just print the error message to stderr and not open a pager.
- Josh Triplett
signature.asc
Description: PGP signature
signature.asc
Description: OpenPGP digital signature
