severity 408341 wishlist
thank you

> Package: mac-fdisk
> Version: mac-fdisk
> Severity: important
> Justification: fails to build from source
>
> Per #202019 it's suggested I (end user) build this from source
> if I want to use it on another arch.  It seems to build ok,
> and the binaries in the package seem to work (from what I see).
> Lots of warnings (My hunch there is no explicit include of
> required #include <strings.h> for bzero etc etc.).  See included
> build typescript for more details.

Building mac-fdisk from unmodified source on any architecture save powerpc
and m68k is not supposed to work, hence your FTBFS bug is not really a
bug. I downgrade it to wishlist for that reason.

Your guess that includes may be missing is quite right - the original code
may have built on mklinux without warnings, but it's always been giving
warnings on Linux. The code worked so I didn't bother.

Now, the fact that the package builds (except for the pmac-fdisk-cross
failure at the end, which is a consequence of ARCH being neither m68k now
powerpc) and the binaries actually run is not too surprising. I would be
amazed, however, if mac-fdisk does read and write correct Apple partition
tables on x86 (or any other little endian architecture, for that matter).
Did you successfully read a Mac-generated partition table, or generate on
that's properly recognized by a Mac?

Last I looked, the partition table entries would have to be converted to
host endianness before manipulating them in-core, and back-converted
before writing a changed table out to disk.

If you're interested in testing this, I can send you a copy of a partition
table in raw format which you can dump to a blank disk (or a loopback
device).

> cc -O2 -g -Wall   -c -o pdisk.o pdisk.c
> In file included from pdisk.c:43:
> kernel-defs.h:18:1: warning: "_IOC_SIZEBITS" redefined
> In file included from /usr/include/asm-i486/ioctl.h:1,
>                  from /usr/include/asm/ioctl.h:8,
>                  from /usr/include/asm-i486/ioctls.h:4,
>                  from /usr/include/asm/ioctls.h:8,
>                  from /usr/include/bits/ioctls.h:24,
>                  from /usr/include/sys/ioctl.h:27,
>                  from pdisk.c:42:
> /usr/include/asm-generic/ioctl.h:24:1: warning: this is the location of the 
> previous definition

That's a bit worrying; I should disable these defines for Linux compiles
...

>       dpkg-gencontrol -pmac-fdisk-cross -ldebian/changelog -isp 
> -Tdebian/mac-fdisk-cross.substvars -Pdebian/mac-fdisk-cross
> dpkg-gencontrol: error: package mac-fdisk-cross not in control info
> dh_gencontrol: command returned error code 65280
> make: *** [binary-arch] Error 1
> [EMAIL PROTECTED]:~/mac-fdisk-0.1$ exit

That I need to fix; pmac-fdisk-cross is a partition table editor for
PowerPC (other than Mac, that is) to handle PC style partition tables
which were used on these PowerPC systems. fdisk/cfdisk had no endianness
fixes at that time. Perhaps it's best to not have this built anymore.

        Michael


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to