Package: hardinfo
Version: 0.4.1-8
Severity: important
Tags: patch upstream

Hi,

as you can see in the build log[0] on powerpc, there's a problem with an
implicit conversion (here, this is a symlink to linux/ppc):

,---
| In file included from computer.c:70:
| ./arch/this/processor.h: In function 'processor_get_info':
| ./arch/this/processor.h:77: warning: format '%.2f' expects type
| 'double', but argument 4 has type 'gint'
`---

 0. http://buildd.debian.org/build.php?&pkg=hardinfo&ver=0.4.1-8&arch=powerpc


And that causes a segfault (a backtrace doesn't show anything useful,
except that the problem happens somewhere in strlen).

Please find attached a patch adding an explicit conversion -- and also a
missing carriage return -- which fixes that problem.

Setting severity to important since a segfault occurs on a very basic
usage and since one cannot generate a report by default, without finding
out which item is reponsible for this segfault and disabling it.

Also tagging it upstream and Cc-ing the author. Leandro: Sorry, I'm
currently ouf ot time to give the current version a try. You're welcome
to ping me (e.g. via private mail) in some weeks so that I test it.

Cheers,

-- 
Cyril Brulebois
--- arch/linux/ppc/processor.h~	2007-01-23 07:24:54.000000000 +0100
+++ arch/linux/ppc/processor.h	2007-01-23 07:31:04.000000000 +0100
@@ -62,11 +62,11 @@
 	                       "CPU=%s\n"
 	                       "L2 Cache=%.2f\n"
 	                       "Frequency=%.2fMHz\n"
-	                       "BogoMips=%.2f"
+	                       "BogoMips=%.2f\n"
 	                       "Byte Order=%s\n",
 			       processor->vendor_id,
 			       processor->model_name,
-			       processor->cache_size,
+			       (gfloat) processor->cache_size,
 			       processor->cpu_mhz,
 			       processor->bogomips,
 #if G_BYTE_ORDER == G_LITTLE_ENDIAN

Reply via email to