tags 407581 + pending
thanks
[EMAIL PROTECTED] writes:
> 1) Script is largely exim4 specific. Logic to determine the MTA in use on
> the
> system should be run prior to MTA specific code.
> At current moment, I would suggest adding logic to detect the presence
> of exim4 before proceeding with the exim specific portion of the cron.daily
> script.
>
> 2) Poor quoting of variables in script.
>
>>From the script
> if [ ! $SPOOLDIR eq $SPOOLDIRDEFAULT ]; then
> # and there is the default spool directory
> if [ -d $SPOOLDIRDEFAULT ]; then
>
>
> Should be something of the form
> if [ ! "$SPOOLDIR" eq "$SPOOLDIRDEFAULT" ]; then
> # and there is the default spool directory
> if [ -d "$SPOOLDIRDEFAULT" ]; then
>
> $SPOOLDIR may be the empty string. Without quoting this will
> confuse the test builtin ("[") in the shell leading to erroneous
> results.
1) Pending, see #305239
2) Now also pending. These variables should only be empty on very
obsure conditions, but this way it's cleaner.
--
Regards
Simon Walter
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
