Hi Thanks for the report. I tink this is a good patch. Do you have an other opinon Micah?
Regards, // Ola On Sun, Jan 07, 2007 at 09:18:12PM -0800, Vagrant Cascadian wrote: > Package: util-vserver > Version: 0.30.211-6 > Severity: important > Tags: patch > > i knew there was a corner case where doing forcestop in the stop > function wasn't right: > > invoke-rc.d util-vserver restart > > only servers marked for starting at boot are restarted, but all vservers > are stopped. > > i think, skipping the forcestop when called with the "restart" argument > would be better behaviour: > > ### > --- /etc/init.d/util-vserver 2006-11-29 16:51:56.000000000 -0700 > +++ util-vserver 2007-01-07 22:07:10.000000000 -0700 > @@ -146,7 +146,7 @@ > then > /usr/lib/util-vserver/vserver-wrapper stop; > fi > - if [ "$ALWAYS_STOP" = "true" ] > + if [ "$ALWAYS_STOP" = "true" ] && [ "$1" != "restart" ] > then > forcestop > fi > ### > > maybe there's better ways to handle it long-term(always restarting all > servers?), but that's because there is always room for improvement :) > > live well, > vagrant > > -- --------------------- Ola Lundqvist --------------------------- / [EMAIL PROTECTED] Annebergsslingan 37 \ | [EMAIL PROTECTED] 654 65 KARLSTAD | | +46 (0)54-10 14 30 +46 (0)70-332 1551 | | http://opalsys.net/ UIN/icq: 4912500 | \ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 / --------------------------------------------------------------- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
