Package: puppetmaster
Version: 0.20.1-1
Severity: minor
Tags: patch

Basically, start-stop-daemon tries to use the parameter passed to --exec to
check for already-running instances of the daemon.

However, as was noted in #378382, the actual process name puppetmaster runs
under is 'ruby', so this check will never match.

If one changes --exec to --startas (as in the patch below) then
start-stop-daemon will detect the already-running instance, rather than
starting puppetmaster and having the user see the socket bind fail.

You could also add --exec ruby to both the start and stop calls, to be sure
that some other process hasn't lucked out and gotten that PID and then finds
itself killed unexpectedly, but that's less useful as it won't protect ruby
processes, and it looks like puppetmaster's pretty good about cleaning up its
own .pid file.

--- puppetmaster.org    2007-01-07 21:31:24.000000000 +1100
+++ puppetmaster        2007-01-07 21:31:27.000000000 +1100
@@ -14,7 +14,7 @@
 
 start_puppetmaster() {
        start-stop-daemon --start --quiet --pidfile /var/run/$NAME.pid \
-               --exec $DAEMON -- $DAEMON_OPTS
+               --startas $DAEMON -- $DAEMON_OPTS
 }
 
 stop_puppetmaster() {

-- System Information:
Debian Release: 4.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-3-686
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)

-- 
Paul "TBBle" Hampson, [EMAIL PROTECTED]

Shorter .sig for a more eco-friendly paperless office.

Attachment: pgpBWrII3QBNk.pgp
Description: PGP signature

Reply via email to