On Wed, Jan 03, 2007 at 04:27:32PM -0700, dann frazier wrote: > On Wed, Jan 03, 2007 at 11:51:32PM +0100, Bastian Blank wrote: > > On Tue, Jan 02, 2007 at 03:34:07PM -0700, dann frazier wrote: > > > Here's a patch that simply uses hardcoded definitions instead of > > > doing the dynamic tests that require architecture-specific scripts. > > > > We hardcode the compiler version also. > > Yes, but we do not hardcoce specific versions of objdump or readelf, which > are also used by these scripts to generate their output.
readelf is only used to detect problems with the compiler and the assembler. > My primary concern is that, in the future, the output of these scripts > will change and we (or our successors) will either not notice or > forget to update the hardcoded values. Thats why I say you should remove the code completely; it is not longer possible to change it without getting completely different results. Bastian -- "Beauty is transitory." "Beauty survives." -- Spock and Kirk, "That Which Survives", stardate unknown -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]