On Fri, 2006-12-15 at 21:44 -0500, Justin Pryzby wrote:
> Hi Sam,
>
> I created a patch to fix Debian's checkrestart tool. I would very much
> like to continue using lsof, since it includes things besides from the
> "maps" file (like fd's, exe's, and working directories). On the other
> hand, it takes multiple cases to handle the different ways that a
> pathname can be
>
> Anyway, since you seem to know infinitely more python than me, I was
> hoping you could take a look at my patch; there are probably much better
> ways of doing what's necessary.
Hi Justin & all, I'm sorry I haven't replied to you before now--I was
out of town until yesterday evening. The patch looks fine, I have two
comments:
* On my system I don't see the difference in lsof output between
lsof, lsof -X and lsof +X.
* You could replace re.compile("DEL").search(f) with f.find
("DEL") though perhaps f.endswith ("DEL") would be better
But they are very minor issues and I think the patch is fine in its
current/accepted form too. Here's hoping the RMs let the fixed package
into Etch!
--
Sam Morris
http://robots.org.uk/
PGP key id 1024D/5EA01078
3412 EA18 1277 354B 991B C869 B219 7FDB 5EA0 1078
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
