On Tue, Mar 22, 2005 at 09:15:55PM +0000, Roger Leigh wrote:
> Package: yaboot
> Version: 1.3.13-3
> Severity: normal
> Tags: patch
> 
> ybin and mkofboot hardcode /dev/nvram as the nvram device.  devfs (and

mkofboot is a symlink to ybin.  your patches are redundant.

> udev, using devfs.rules) use /dev/misc/nvram instead.

devfs is obsolete and slated for removal from 2.6 soon.

> The attached patch checks for both devices so that it will work on
> both systems.

since devfs is going away is this really necessary?  users of udev
probably use the sensible traditional naming, and can more easily fix
the udev rules to put the nvram device is the correct location.

> Please note that this patch depends upon #300946 to be fixed in
> nvsetenv (powerpc-utils) before this patch will have any effect.

unless nvsetenv gets changed this patch should not be applied
as it will prevent ybin from doing proper error checking.  (ybin
should not accept non-standard /dev/nvram locations if nvsetenv will
not). 

-- 
Ethan Benson
http://www.alaska.net/~erbenson/

Attachment: pgpJ62a79LIIU.pgp
Description: PGP signature

Reply via email to