Bug#300907: wmmount: User supplied commands should use the PATH environment and report errors

[Pierre Pronchery]

Package: wmmount
Version: 1.0beta2-6
Severity: wishlist
Tags: patch


Commands currently defined through "opencmd" are exec'd using execv(),
thus ignoring the user's PATH environment. This is even more confusing
since the supplied configuration files samples call "kfmclient" directly
for instance.

Please find attached my trivial patch for this problem. It also calls
perror() when exec() would fail.

Best regards,

-- System Information:
Debian Release: 3.1
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.4.29
Locale: LANG=en_US.ISO-8859-15, LC_CTYPE=en_US.ISO-8859-15 (charmap=ISO-8859-15)

Versions of packages wmmount depends on:
ii  libc6                    2.3.2.ds1-20    GNU C Library: Shared libraries an
ii  xlibs                    4.3.0.dfsg.1-10 X Keyboard Extension (XKB) configu

-- no debconf information

--- wmmount-1.0beta2/wmmount.c  2005-03-22 16:53:43.000000000 +0100
+++ wmmount-1.0beta2.khorben/wmmount.c  2005-03-22 16:53:29.000000000 +0100
@@ -863,7 +863,8 @@
   if(pid==0) {
     if(path!=NULL)
       chdir(path);
-    execv(argv[0], argv);
+    execvp(argv[0], argv);
+    perror(argv[0]);
     free(argv);
     free(buf);
     exit(127);