The provided patch is broken: standard error is redirected to a file named "1" instead of file handle 1. Suggest to use the following syntax instead: modprobe -q <module> || true
Also, I wonder if all listed modules really need to be modprobed individually: modprobe will after all load modules that other modules depend on automatically. I would expect that i2c-powermac and windfarm_core can safely be dropped. So please only modprobe those modules that are strictly needed to enable the fan control. Finally, why was S50directfb-linux-powerpc added in the Makefile? This seems unrelated to this patch. Colin suggested that when we apply this patch in the installer, a similar patch should added in initramfs-tools to make sure that the modules are loaded too on the installed system. Has that already been coordinated? P.S. The main reason (beside the fact that the patch was broken) that I reverted the upload was that normal NMU procedure was not followed: - an NMUer never adds himself to Uploaders - an NMU uses a different version number from normal uploads - bug closure was missing - there was no mail to the open BR with a final patch based on the debdiff for the upload
pgpTyNtKwVfDa.pgp
Description: PGP signature
