Hi again Now I have tested your patch and it worked quite well. Not perfect though and I'll give you the explanation why.
fgets (not a C++ thing...) actually read the string and include the newline character. This means that it has to be replaced with a null character in order for hostname lookup to work fine. It probably worked for you when you typed host:id but if you just type hostname and assume default id 0, then it do not work that well. I found it by mistake. I also changed it to remove the \n, but that is more of a personal opinion of mine. :) Thanks a lot! I'll probably upload this tomorrow. I want to have the new option documented for etch and you have done that in such a nice way. Regards, // Ola On Wed, Nov 08, 2006 at 02:46:07PM +0100, Luca Capello wrote: > Hi Ola! > > On Tue, 07 Nov 2006 11:23:44 +0100, Ola Lundqvist wrote: > > On Tue, Nov 07, 2006 at 10:56:38AM +0100, Luca Capello wrote: > >> On Tue, 07 Nov 2006 10:37:41 +0100, Ola Lundqvist wrote: > >>> The current solution is to have a -PasswordDialog option. I > >>> actually think this option should be changed to -XDialogs instead > >>> and apply to all input methods. > >> > >> Completely agree. > > > > Nice. > > At least for the ServerDialog and the PasswordDialog this is quite > simple and the attached patches seem to work. It needs to be > checked, because as I already said, I'm a true beginner in C++, so > maybe it's not correct (or it misses something). > > I tested it on xterm/ratpoison [1] and on openbox (sorry, no > DesktopEnvironment here...) and it seems to work as expected. > > The set of sequential patches is against the Debian sources, thus > isn't suitable yet for inclusion in a debian package. Here a small > ChangeLog: > > 1) remove duplicated <termios.h>/<stdio.h> and move them to the > beginning of include (together with "general" includes like > <unistd.h>) > 2) s/UserPassDialog/XDialog/g > 3) code cleanup (this is basically to keep the upstream style on > if/else statements and only one IMHO better line spacing) > 4) add XDialog check for vncServerName > 5) add a \n before prompting for server, username and password > (which IMHO is "graphically" better on console [2]) > 6) update the manpage (which as per #394072 [3] lacks the > -PasswordDialog option and I don't think it's worth to fix that > bug before fixing this one) > > For the error dialog windows, the situation is different: from what I > can understand at a very fast code checking, we need to modify some > functions (*Exception) in common/rfb/ or common/rdr/. Thus I need a > bit more time :-) > > Any comments? > > Thx, bye, > Gismo / Luca > > Footnotes: > [1] if you use the ratpoison exec command (or the menu entry provided > together with the 9menu package), this obviously fails, because it > execute a shell command and thus vncviewer thinks it's on the > console (but you cannot see anything). I don't know how to solve > this problem :-( > [2] I don't know why a new line is printed after the Server: question > and not after the Password: one and I even unsuccessfully tried to > strip down the \n when fgets(vncServerName). IMHO the best option > would be to have "\nQuestion: \n", but these are minor stuff > [3] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=394072 > -- --------------------- Ola Lundqvist --------------------------- / [EMAIL PROTECTED] Annebergsslingan 37 \ | [EMAIL PROTECTED] 654 65 KARLSTAD | | +46 (0)54-10 14 30 +46 (0)70-332 1551 | | http://www.opal.dhs.org UIN/icq: 4912500 | \ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 / --------------------------------------------------------------- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
