Package: module-assistant
Version: 0.10.7
Severity: important

Really odd things happen if the environment variable VERSION is defined
or set before calling module-assistant.

Given an invocation as in
| module-assistant build <module>--non-inter --kernel-dir /home/linux \
|     --userdir . --text-mode -f
(tested for <madwifi> and <rt2500> and a third off-Debian package)

a) "export VERSION=foobar" before build
builds the module but fails with the last lines:

| dh_gencontrol -- -vfoobar
| dh_md5sums
| dh_builddeb --destdir=/tmp
| dpkg-deb - error: (upstream) version (`foobar') doesn't contain any digits

b) "export VERSION=" before build
fails a bit earlier for an empty VERSION:

| dh_gencontrol -- -v
| dpkg-gencontrol: unknown option `-v'
| 
| Usage: dpkg-gencontrol [<option> ...]
(...)


The reason for this is at about line 145 in
/usr/share/modass/include/generic.make which assumes any present value
of VERSION is valid which might not be the case if the value is taken
from the environment.

Solution: Please strip VERSION from the environment before doing any
further calls, for example by doing:


--- /usr/bin/module-assistant.OLD       2006-10-14 00:08:51.000000000 +0000
+++ /usr/bin/module-assistant   2006-10-31 00:50:02.000000000 +0000
@@ -29,6 +29,7 @@
   }
 }

+delete $ENV{'VERSION'};
 chomp($rows=`tput lines`);
 chomp($columns=`tput cols`);
 $rows=25 if !$rows;

    Christoph

-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18.1
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages module-assistant depends on:
ii  libtext-wrapi18n-perl         0.06-5     internationalized substitute of Te
ii  perl                          5.8.8-6.1  Larry Wall's Practical Extraction 

Versions of packages module-assistant recommends:
ii  liblocale-gettext-perl        1.05-1     Using libc functions for internati

-- no debconf information

Attachment: signature.asc
Description: Digital signature

Reply via email to