severity 396180 wishlist tags 396180 pending thanks On Mon, Oct 30, 2006 at 05:25:04PM +0100, Loïc Minier wrote: > On Mon, Oct 30, 2006, Martin Pitt wrote: > > unicode.c:19:26: error: linux/string.h: No such file or directory > > Thanks Martin. Aurélien complained on IRC that this would introduces > new "implicits declarations" warnings. I've grabbed the source of
I still did not test it when I said that, it was *only* a first assumption from my part, you must have misunderstood me. It is also true that I have been very quick to judge, since it is an Ubuntu bug reported on the Debian BTS. I also retaliated quickly after my misjudgment. > hfsplus, and built it without and with your patch, and I got exactly > the same warnings (apart of line numbers), and no new warning at all. > > So I second your request to drop this bogus #include. It does *not* FTBFS on Debian Sid or Etch, so it is a wishlist bug for Debian which, of course, I am willing to fix, despite Loïc's insidious comments. Indeed, I checked and the file unicode.c does not use any of the definitions in /usr/include/linux/string.h. Probably a very old leftover from an exhausted upstream, who knows? ;P Martin, on a side note, I would really be curious to know why /usr/include/linux/string.h disappeared from Ubuntu? :) > Aurélien, would you be so kind to suggest this upstream? No, upstream is not active anymore and does not care. Is it also my fault? Come on, please... > (I'm noting this here in case Aurélien didn't read my reply on IRC.) Again, adhominem stuff... Like if I never answered people on IRC... Like if I did not maintain my packages... Instead of bashing me like the evil NM which I am not, would you be so kind to sponsor this upcoming upload? ;) Cheers, -- .''`. Aurélien GÉRÔME : :' : `. `'` Free Software Developer `- Unix Sys & Net Admin
signature.asc
Description: Digital signature
