On Wed, Oct 25, 2006 at 04:57:32PM +0300, Eddy Petrișor wrote: > Paul TBBle Hampson wrote: >> Line 51 (log probe-finished) prolly should be outside the while [ ! -f >> /tmp/probe-finished ]
> err, at 51 there is a "log pppoe probe output size" and is there to be > able to debug if there is any output from pppoe-discovery which should > end the probe. Oh, didn't realise that was for that. I assumed it was supposed to show the result that had already caused the loop to terminate... >> It'd be nice if pppoe-discovery returned immediately on detection of >> any PPPoE Access Concentrator, rather than continuing to listen for >> further reponses, as it is being used only to determine if any access >> concentrators are out there. > This should be the default behaviour. Do you have any reasons to belive > otherwise? When run at the command line, it immediately saw the access concentrator, but hung around for several more seconds before returning the command prompt. Most of the time when I ran it and watched, it seemed to keep reporting Timout (sic) even on the correct interface. When I wasn't watching, I didn't notice it being slow... This is consistent with my memory of how pppoe -A operates too. >> Anyway, with these fixes, it seems to work OK, although the resolv.conf test >> on >> line 196 also seemed to fail for me after the pppoe detection had succeeded >> but >> ppp failed to dial up, so I suspect that -e is the wrong test. (I'm guessing >> it's returning false for a dangling symlink) or the ln -s should be ln -sf. > I have rewritten that part as an effort to make the pppoe detection play > more nicely with the netcfg default configuration. Ah yes, I see #385150... I was looking at the ppp bugs, not the ppp-udeb bugs, silly me. > Thanks for the tests and reported issues. Glad to be able to help. ^_^ -- ----------------------------------------------------------- Paul "TBBle" Hampson, B.Sc, LPI, MCSE On-hiatus Asian Studies student, ANU The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361) [EMAIL PROTECTED] Of course Pacman didn't influence us as kids. If it did, we'd be running around in darkened rooms, popping pills and listening to repetitive music. -- Kristian Wilson, Nintendo, Inc, 1989 License: http://creativecommons.org/licenses/by/2.1/au/ -----------------------------------------------------------
pgpCwzWnhYSOj.pgp
Description: PGP signature
