Package: neon26
Severity: normal
Tags: upstream

Hi,

If sizeof(off_t) is not equal to 4, neon disables LFS support because it is
unnecessary. Basically, this is fine. However, a user has no way to tell if
LFS support was disabled because it is not available or because it is not
required.

Imho, the best way to solve this problem is the following:

if sizeof(off_t) >= 8:
        - enable LFS support so the user knows that it is available
        - typedef off_t ne_off_t
else if LFS support is available by any other means already implemented:
        - enable LFS support
        - typedef off64_t ne_off_t (or whatever else might be necessary)
else:
        - disable LFS support
        - typedef off_t ne_off_t

Now, do not define functions foo and foo64 depending on whether LFS support is
available but define function foo using ne_off_t for any offset parameters.

Cheers,
Sebastian

-- 
Sebastian "tokkee" Harl
GnuPG-ID: 0x8501C7FC
http://tokkee.org/

Attachment: signature.asc
Description: Digital signature

Reply via email to