Package: kino Version: 0.92-1 Severity: minor Tags: patch
Hello!
All files captured with kino are always *not* group-writable, even if
the umask is 002. This small misfeature is somewhat annoying for me
(I *need* captured files to be group-writable for a reason). In
general, I think captured files are not sensitive data so kino should
just rely on umask (default ACLs/whatever):
Index: kino-0.90/src/filehandler.cc
===================================================================
--- kino-0.90.orig/src/filehandler.cc 2006-09-15 19:34:09.000000000 +0400
+++ kino-0.90/src/filehandler.cc 2006-09-15 19:35:11.000000000 +0400
@@ -346,7 +346,7 @@
bool RawHandler::Create( const string& filename )
{
- fd = open( filename.c_str(), O_CREAT | O_TRUNC | O_RDWR | O_NONBLOCK,
0644 );
+ fd = open( filename.c_str(), O_CREAT | O_TRUNC | O_RDWR | O_NONBLOCK,
0666 );
if ( fd != -1 )
{
FileTracker::GetInstance().Add( filename.c_str() );
@@ -722,7 +722,7 @@
{
Init();
- if ( open( filename.c_str(), O_CREAT | O_TRUNC | O_RDWR | O_NONBLOCK,
0644 ) != -1 )
+ if ( open( filename.c_str(), O_CREAT | O_TRUNC | O_RDWR | O_NONBLOCK,
0666 ) != -1 )
{
fd = quicktime_open( const_cast<char*>( filename.c_str() ), 0,
1 );
if ( fd != NULL )
Index: kino-0.90/src/riff.cc
===================================================================
--- kino-0.90.orig/src/riff.cc 2006-09-15 19:35:21.000000000 +0400
+++ kino-0.90/src/riff.cc 2006-09-15 19:36:19.000000000 +0400
@@ -134,7 +134,7 @@
bool RIFFFile::Create( const char *s )
{
- fd = open( s, O_RDWR | O_NONBLOCK | O_CREAT | O_TRUNC, 00644 );
+ fd = open( s, O_RDWR | O_NONBLOCK | O_CREAT | O_TRUNC, 00666 );
if ( fd == -1 )
return false;
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/dash
Kernel: Linux 2.4.33.2-grsec-acl-i686-smp
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8)
Versions of packages kino depends on:
ii libasound2 1.0.13-1 ALSA library
ii libatk1.0-0 1.12.3-1 The ATK accessibility toolkit
ii libavc1394-0 0.5.3-1+b1 control IEEE 1394 audio/video devi
ii libc6 2.3.6.ds1-6 GNU C Library: Shared libraries
ii libcairo2 1.2.4-3.1 The Cairo 2D vector graphics libra
ii libdv4 1.0.0-1 software library for DV format dig
ii libfontconfig1 2.4.1-2 generic font configuration library
ii libgcc1 1:4.1.1-16 GCC support library
ii libglade2-0 1:2.6.0-2 library to load .glade files at ru
ii libglib2.0-0 2.12.4-1 The GLib library of C routines
ii libgtk2.0-0 2.8.20-3 The GTK+ graphical user interface
ii libice6 1:1.0.1-2 X11 Inter-Client Exchange library
ii libpango1.0-0 1.14.7-1 Layout and rendering of internatio
ii libpng12-0 1.2.8rel-7 PNG library - runtime
ii libraw1394-8 1.2.1-2 library for direct access to IEEE
ii libsamplerate0 0.1.2-2 audio rate conversion library
ii libsm6 1:1.0.1-3 X11 Session Management library
ii libstdc++6 4.1.1-16 The GNU Standard C++ Library v3
ii libx11-6 2:1.0.3-2 X11 client-side library
ii libxcursor1 1.1.7-4 X cursor management library
ii libxext6 1:1.0.1-2 X11 miscellaneous extension librar
ii libxfixes3 1:4.0.1-4 X11 miscellaneous 'fixes' extensio
ii libxi6 1:1.0.1-3 X11 Input extension library
ii libxinerama1 1:1.0.1-4.1 X11 Xinerama extension library
ii libxml2 2.6.26.dfsg-4 GNOME XML library
ii libxrandr2 2:1.1.0.2-4 X11 RandR extension library
ii libxrender1 1:0.9.1-3 X Rendering Extension client libra
ii libxv1 1:1.0.2-1 X11 Video extension library
ii zlib1g 1:1.2.3-13 compression library - runtime
kino recommends no packages.
-- no debconf information
Best regards,
Alexei
--
All science is either physics or stamp collecting.
signature.asc
Description: Digital signature
