Package: cdrdao
Version: 1:1.2.1-7
Severity: important

I came across this while working on packages with unnecessary dependencies.
It turns out that cdrdao currently depends on the Ogg and Vorbis libraries
without using them.

It's clearly supposed to use them, however.  There's bad behavior in the 
configure
script.  So the bug is that it doesn't use them, and it should.

Unfortunately, the upstream configure script has the perverse result that if
--with-ogg-support is supplied on the command line, ogg support will be 
DISABLED.

Unfortunately, debian/rules does this:
  CFLAGS="$(CFLAGS)" ./configure --host=$(DEB_HOST_GNU_TYPE) 
--build=$(DEB_BUILD_GNU_TYPE
) --prefix=/usr --mandir=\$${prefix}/share/man --without-lame --with-ogg-support

And triggers this perverse behavior.

There are two ways to fix this.  You can in fact apply both fixes 
simultaneously.
1) The dead easy way: remove --with-ogg-support from debian/rules.  After all, 
Ogg
support is there by default.  Alternately, specify --with-ogg-support=yes, which
will work correctly.
2) The clean way: fix upstream's configure.ac and rerun autoconf.
This should probably be sent upstream.

With modern autoconf, --with-ogg-support sets $with_ogg_support to the empty 
string.
So the empty string needs to be interpreted as a "yes".  But that's not done in
upstream's configure.ac.
There are several ways to fix upstream's configure.ac.

Perhaps the easiest way is to replace this line:
------
AC_ARG_WITH(ogg-support,[  --with-ogg-support      enable OGG format support 
(default is
YES)],[],[with_ogg_support=yes])
-------
with this line:
-------
AC_ARG_WITH(ogg-support,[  --with-ogg-support      enable OGG format support 
(default is YES)],
[if test x$with_ogg_support = x ; then with_ogg_support=yes; 
fi],[with_ogg_support=yes])
-------
And the same should be done for the mp3-support line while you're at it, since 
it
has the same problem.

An alternate, and perhaps more robust, fix, is to replace all instances of 
  test "$with_ogg_support" = yes
with
  test "$with_ogg_support" != no

and do the same for with_mp3_support.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to