This one time, at band camp, David Berg said: > I have added some comments to /etc/init.d/hdparm as well as fixed some > indenting problems that made it difficult for me to understand how the > script was working. I thought I'd share them. I also made some > comments in the /etc/hdparm.conf file describing a bit more on how it > is supposed to be organized and how the init script reads it. > > I noticed that the set_option() routine placed a -q after every > argument if 'quiet' was in the conf file. I removed the lines that > caused this and instead added $[OPT,DEF]_QUIET to the final command > line.
Thanks a lot for doing this! I have been meaning to clean things up, as much of it is patched in stuff that has slowly accumulated without being properly documented or merged stylistically. The reason set_option adds a -q after each option is that this is apparently the only way to suppress output for multiple options passed on the same command line. Including it only once suppresses only the first operation (this is likely a bug with upstream, but since it easy to work around, I have never bothered). Thanks again, -- ----------------------------------------------------------------- | ,''`. Stephen Gran | | : :' : [EMAIL PROTECTED] | | `. `' Debian user, admin, and developer | | `- http://www.debian.org | -----------------------------------------------------------------
pgp0IyjDSXinp.pgp
Description: PGP signature
