Package: systemimager-server
Version: 3.2.3-6sarge2
Severity: normal

Hi, 
I was using getimage to make a backup of a woody host before upgrading to sarge.

This is what happened:
  foo# prepareclient
  <finishes normally>

  master# getimage -golden-client foo -image foo -exclude /data/
  <creates the image ok>
  <asks me about IP address assignment>
    I choose 3, 'replicant', viz:
  Which method do you prefer? [1]: 3
  You have chosen method 3 for assigning IP addresses.

  Are you satisfied? ([y]/n): y
  File does not exist: 
/var/lib/systemimager/images/foo/etc/systemimager/autoinstallscript.conf at 
/usr/lib/systemimager/perl/SystemImager/Server.pm line 1133
  master# echo $?
  255

  master# ls /var/lib/systemimager/images/foo/etc/systemimager/
  devices_by_label.txt  partitionschemes
  mounted_filesystems   updateclient.local.exclude

  The ouptut directory is indeed writeable by root.

This is not the expected behaviour :)
The problem appears to be that getimage runs validate_auto_install_script_conf
(where the code fails out) before it runs create_autoinstall_script.

The patch below appears to resolve that problem, but I'm amazed a bug
like this slipped through. It's possible the problem comes from somewhere
else entirely.

Applying that patch, deleting the image and rerunning produces a new error:
  File does not exist: 
/var/lib/systemimager/images/Power_Edge_1850_foo/etc/systemimager/autoinstallscript.conf
 at /usr/lib/systemimager/perl/SystemImager/Server.pm line 337

This comes from inside create_autoinstall_script(), the call to
_read_partition_info_and_prepare_parted_commands() also expects that the
$auto_install_script_conf file has already been created. During its creation!?

Is the problem that prepareclient should have created
/etc/systemimager/autoinstallscript.conf ? It doesn't seem so from the code.

  foo# ls /etc/systemimager
  devices_by_label.txt  partitionschemes
  mounted_filesystems   updateclient.local.exclude

If this is the problem, it seems pretty lame to break backwards compatibility
so badly, but if that's what happened then perhaps this bug should be retitled: 

 getimage does not advise of missing autoinstallscript.conf on golden client

It does check for the mounted_filesystems file, so why not this file?

At this point I think I must have misdiagnosed something and it's time to
call in the experts. Help, please.


--- getimage.orig       2006-09-20 09:42:26.000000000 +1000
+++ getimage    2006-09-20 10:47:57.000000000 +1000
@@ -555,9 +555,8 @@
     $auto_install_script_conf = 
"${imagedir}/etc/systemimager/autoinstallscript.conf";
 }
 
-SystemImager::Server->validate_auto_install_script_conf( 
$auto_install_script_conf );
-
-SystemImager::Server->create_autoinstall_script(
+unless ( -f $auto_install_script_conf ) {
+    SystemImager::Server->create_autoinstall_script(
        $script_name,
        $autoinstall_script_dir,
        $config_dir,
@@ -567,7 +566,11 @@
        $post_install,
         $no_listing,
     $auto_install_script_conf
-);
+    );
+}
+
+SystemImager::Server->validate_auto_install_script_conf( 
$auto_install_script_conf );
+
 ### END create a fresh master autoinstall script ###
 
 # prompt to run "addclients"

------------------------------------eop----------------------------------------

-- System Information:
Debian Release: 3.1
Architecture: i386 (i686)
Kernel: Linux 2.4.27-2-386
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages systemimager-server depends on:
ii  binutils                  2.15-6         The GNU assembler, linker and bina
ii  debianutils               2.8.4          Miscellaneous utilities specific t
ii  dosfstools                2.11-2         Utilities to create and check MS-D
ii  libappconfig-perl         1.56-2         Perl module for configuration file
ii  libxml-parser-perl        2.34-4         Perl module for parsing XML files
ii  libxml-simple-perl        2.14-1         Perl module for reading and writin
ii  mkisofs                   4:2.01+01a01-2 Creates ISO-9660 CD-ROM filesystem
ii  mtools                    3.9.9-2.1      Tools for manipulating MSDOS files
ii  perl                      5.8.4-8sarge3  Larry Wall's Practical Extraction 
ii  rsync                     2.6.4-6        fast remote file copy program (lik
ii  systemconfigurator        2.0.10-1       Unified Configuration API for Linu
ii  systemimager-boot-i386-st 3.2.3-6sarge2  SystemImager boot binaries for i38
ii  systemimager-common       3.2.3-6sarge2  Utilities and libraries common to 

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to